fix(filesystem): reject move_file when destination exists - #4668
Open
re2zero wants to merge 1 commit into
Open
Conversation
The move_file tool's documentation states it fails if the destination exists, but the implementation used fs.rename directly without checking, silently overwriting the destination. Add an existence check via fs.stat before the rename, matching the documented behavior. If the destination exists, throw an error immediately. Fixes modelcontextprotocol#4628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4628
Problem
move_filesilently overwrites an existing destination file even though the README and the tool description both state it will fail if the destination exists. This is a data-loss bug: an agent that trusts the documented safety contract can destroy files.Fix
Add an existence check via
fs.statbeforefs.rename. If the destination already exists, an error is thrown immediately, matching the documented contract.Testing
server-filesystemtest suite: 152 passed (7 test files).