Skip to content

fix: correct tap log format verb and openrpc allocationId schema drift #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmegidish merged 1 commit into from
Aug 25, 2026
Merged

fix: correct tap log format verb and openrpc allocationId schema drift #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devices/ios.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@ func (d *IOSDevice) clickStartBroadcastButton() error {
}
centerX := buttons[0].Rect.X + buttons[0].Rect.Width/2
centerY := buttons[0].Rect.Y + buttons[0].Rect.Height/2
utils.Verbose("Tapping record button at %f,%f", centerX, centerY)
utils.Verbose("Tapping record button at %d,%d", centerX, centerY)
if err = d.Tap(centerX, centerY); err != nil {
return fmt.Errorf("failed to tap broadcast button: %w", err)
}
Expand Down
4 changes: 2 additions & 2 deletions docs/openrpc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1825,9 +1825,9 @@
"type": "string",
"description": "Provider type (e.g. 'mobilenext', 'local')"
},
"sessionId": {
"allocationId": {
"type": "string",
"description": "Session identifier for this device allocation"
"description": "Allocation identifier for this device"
}
},
"required": [
Expand Down
2 changes: 1 addition & 1 deletion docs/openrpc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,7 +1768,7 @@ Describes where the device is provided from
| Property | Type | Required | Description |
|----------|------|----------|-------------|
| `type` | `string` | ✓ | Provider type (e.g. 'mobilenext', 'local') |
| `sessionId` | `string` | | Session identifier for this device allocation |
| `allocationId` | `string` | | Allocation identifier for this device |

### Rect

Expand Down
Loading