Skip to content

fix: correct tap log format verb and openrpc allocationId schema drift - #362

Merged
gmegidish merged 1 commit into
mainfrom
fix/openrpc-allocation-id
Aug 25, 2026
Merged

fix: correct tap log format verb and openrpc allocationId schema drift#362
gmegidish merged 1 commit into
mainfrom
fix/openrpc-allocation-id

Conversation

@gmegidish

@gmegidish gmegidish commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

Two small review fixes: a wrong format verb in a verbose log, and OpenRPC schema drift for the DeviceProvider allocation field.

Changes

  • devices/ios.go — the record-button tap log used %f for centerX/centerY, which are int (printed %!f(int=...)); now %d,%d.
  • docs/openrpc.jsonDeviceProvider schema declared sessionId, but the Go struct serializes allocationId (devices/common.go) and findDeviceByAllocation matches on allocationId; renamed the property to match.
  • docs/openrpc.md — regenerated via make docs.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

On-demand reviews are free for the next 26 days. After that, they cost $0.25 per reviewed file.

Or wait 45 minutes for your next included review.

View limit details

Limit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6ae28898-ccfc-4b4e-b78f-0ab8e14d2030

📥 Commits

Reviewing files that changed from the base of the PR and between dcb6c9e and 7332c06.

⛔ Files ignored due to path filters (2)
  • docs/openrpc.json is excluded by !docs/**
  • docs/openrpc.md is excluded by !**/*.md, !docs/**
📒 Files selected for processing (1)
  • devices/ios.go

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit 0eef0b5 into main Aug 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant