Skip to content

fix: unpin modelparams in the unpublished MCP package #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumegay13 merged 2 commits into from
Aug 19, 2026
Merged

fix: unpin modelparams in the unpublished MCP package #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4697ac8
fix: unpin modelparams in the unpublished MCP package
guillaumegay13 Aug 19, 2026
72b0eea
test: cover sibling repinning with a fixture, not the unpinned MCP pa…
guillaumegay13 Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/modelparams-mcp/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ One entry documents one wire format, so `validate_model_params` answers for the

The catalog is compiled in at publish time from the YAML source of truth at [github.com/mnfst/modelparams.dev](https://github.com/mnfst/modelparams.dev/tree/main/models). No runtime fetch, no cache to invalidate — update the package to get new models.

The hosted endpoint is rebuilt with the site on every catalog change, so it always answers from the current catalog. A local build of this package pins an exact [`modelparams`](https://www.npmjs.com/package/modelparams) dependency instead, and answers from whichever catalog version that pin resolves.
The hosted endpoint is rebuilt with the site on every catalog change, so it always answers from the current catalog. A local build of this package takes [`modelparams`](https://www.npmjs.com/package/modelparams) straight from this workspace — the dependency is deliberately unpinned, because the package is not published and an exact pin only froze it at a version the workspace had already moved past.

## License

Expand Down
2 changes: 1 addition & 1 deletion packages/modelparams-mcp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
"dependencies": {
"@modelcontextprotocol/sdk": "^1.30.0",
"zod": "^3.25.0",
"modelparams": "0.0.56"
"modelparams": "*"
}
}
30 changes: 23 additions & 7 deletions tests/release-lockfiles.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,27 @@ describe("bumpPackageLockVersion", () => {
expect(split(updated, "modelparams").entry).toContain('"version": "9.9.9"');
});

it("moves the exact sibling pin the MCP package ships in lockstep", () => {
const updated = bumpPackageLockVersion(lock, "9.9.9", "modelparams-mcp", ["modelparams"]);
const { entry } = split(updated, "modelparams-mcp");
expect(entry).toContain('"version": "9.9.9"');
expect(entry).toContain('"modelparams": "9.9.9"');
// No workspace pins a sibling exactly today — modelparams-mcp did until it
// stopped being published — so this exercises the repinning against a
// fixture. Keep it: the day another package pins a sibling, a release that
// moves one and not the other breaks `npm ci` for every job on the PR.
it("moves an exact sibling pin alongside the version", () => {
const fixture = [
"{",
' "packages": {',
' "packages/pinning-workspace": {',
' "version": "0.0.1",',
' "dependencies": {',
' "modelparams": "0.0.1"',
" }",
" }",
" }",
"}",
].join("\n");

const updated = bumpPackageLockVersion(fixture, "9.9.9", "pinning-workspace", ["modelparams"]);
expect(updated).toContain('"version": "9.9.9"');
expect(updated).toContain('"modelparams": "9.9.9"');
});

it("leaves every other entry untouched", () => {
Expand All @@ -36,8 +52,8 @@ describe("bumpPackageLockVersion", () => {
});

it("is idempotent, so a re-prepared release branch converges", () => {
const once = bumpPackageLockVersion(lock, "9.9.9", "modelparams-mcp", ["modelparams"]);
expect(bumpPackageLockVersion(once, "9.9.9", "modelparams-mcp", ["modelparams"])).toBe(once);
const once = bumpPackageLockVersion(lock, "9.9.9", "modelparams");
expect(bumpPackageLockVersion(once, "9.9.9", "modelparams")).toBe(once);
});

it("fails loudly rather than silently skipping an unknown workspace", () => {
Expand Down
Loading