fix: unpin modelparams in the unpublished MCP package - #315
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What changed
packages/modelparams-mcpnow depends onmodelparams: "*"instead of an exact version, in both its package.json and the lockfile💭 Why
Every check on release PR #313 fails with
npm cirefusing the install:The exact pin existed to keep the two published packages in lockstep. #311 stopped publishing
modelparams-mcp, so nothing bumps that pin any more —prepare-releaseonly rewrites themodelparamsworkspace. The pin froze at 0.0.56 while the workspace moved to 0.0.57, and since the release commit is what changes the version, every future release PR would have failed the same way, including the required param guard, so nothing could ever publish again.Unpinning is the fix rather than teaching the release script to bump a package it no longer ships: the package is built only from this checkout, so it should track whatever the workspace holds.
📝 Notes
Reproduced and verified locally: with the pin at 0.0.56, simulating the release bump (
modelparams→ 0.0.57 in package.json + lockfile, exactly what prepare-release writes) makesnpm cifail with the error above; with the pin unpinned, the same simulated bump installs cleanly. Catalog validates and the full test suite passes.Once this lands, the release-prepare workflow regenerates
chore/releasefrom main and #313 should go green.