Skip to content

fix: unpin modelparams in the unpublished MCP package - #315

Merged
guillaumegay13 merged 2 commits into
mainfrom
fix/release-lock-pin
Aug 19, 2026
Merged

fix: unpin modelparams in the unpublished MCP package#315
guillaumegay13 merged 2 commits into
mainfrom
fix/release-lock-pin

Conversation

@guillaumegay13

Copy link
Copy Markdown
Collaborator

✨ What changed

  • packages/modelparams-mcp now depends on modelparams: "*" instead of an exact version, in both its package.json and the lockfile
  • README corrected to match

💭 Why

Every check on release PR #313 fails with npm ci refusing the install:

npm error `npm ci` can only install packages when your package.json and package-lock.json are in sync.
npm error Missing: modelparams@0.0.56 from lock file

The exact pin existed to keep the two published packages in lockstep. #311 stopped publishing modelparams-mcp, so nothing bumps that pin any more — prepare-release only rewrites the modelparams workspace. The pin froze at 0.0.56 while the workspace moved to 0.0.57, and since the release commit is what changes the version, every future release PR would have failed the same way, including the required param guard, so nothing could ever publish again.

Unpinning is the fix rather than teaching the release script to bump a package it no longer ships: the package is built only from this checkout, so it should track whatever the workspace holds.

📝 Notes

Reproduced and verified locally: with the pin at 0.0.56, simulating the release bump (modelparams → 0.0.57 in package.json + lockfile, exactly what prepare-release writes) makes npm ci fail with the error above; with the pin unpinned, the same simulated bump installs cleanly. Catalog validates and the full test suite passes.
Once this lands, the release-prepare workflow regenerates chore/release from main and #313 should go green.

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modelparams.dev Ready Ready Preview Aug 19, 2026 3:28pm

Request Review

@github-actions github-actions Bot added the site Website code or tooling label Aug 19, 2026
@guillaumegay13
guillaumegay13 merged commit 7cc41b9 into main Aug 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

site Website code or tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant