Skip to content

OpenVMM/microVM umbrella: virtio-fs shares, the FUSE server, and file-system identity #1649

Open
0 of 39 issues completed

Description

Objective. The microVM's virtio-fs shares serve every request that a guest can send without aborting the VMM or allocating what the guest declares, enforce the share's policy on every path to a host object, keep each node bound to the host object that it names across unlinks, renames, and hard links, and hold their state within the bounds that a capture and a restore accept. lxutil runs a caller-owned request with only the caller's identity and gives the thread back its own, and OpenVMM's fuse crate turns a file system's out-of-contract result into an error reply instead of an abort.

Children.

Part Issue Scope Blocked by
Transport #1621 Zero-length descriptors in a virtqueue chain end request reads and reply writes early, so valid requests fail. —
Requests #1596 RequestReader::read_count allocates a guest-declared count, up to 4 GiB, before it checks the request's remaining bytes. —
Requests #1607 A FUSE_INIT whose header length is below 40 underflows the payload length, and a build with overflow checks panics. —
Requests #1597 A FUSE_SETATTR time with 10^9 or more nanoseconds panics in Duration::new at u64::MAX seconds, and otherwise carries into the seconds instead of failing with EINVAL. —
Replies #1615 A successful FUSE_IOCTL reply carries the request's input instead of the file system's output. —
Replies #1616 ReplySender::send_arg_data leaves the trailing data out of fuse_out_header.len. —
Replies #1625 ReplySender::send_error(i32::MIN) overflows its negation, and a build with overflow checks panics. —
Replies #1628 A reply longer than u32::MAX bytes panics in make_header. —
Replies #1629 A data reply longer than the guest requested panics in Session::send_max_size. —
Replies #1631 A write or copy_file_range count above u32::MAX panics. —
Session #1630 dispatch_init panics on init flags that the guest did not offer, and trusts capabilities that init can overwrite. —
Identity #1604 The inode dedup key omits the host device number, so objects with the same st_ino on different devices, such as btrfs subvolume roots, share one node. —
Identity #1619 Guest inode numbers omit the host device number, so such objects report the same (st_dev, st_ino) in the guest. —
Identity #1626 A dedup key that an object of another file type reuses is preflighted as an alias, so the node count passes MAX_INODES and a later capture fails. —
Identity #1633 A node's lookup count wraps from u64::MAX to 0, which a restored state can reach, so the next FUSE_FORGET evicts a node that the guest still holds. —
Aliases #1599 A file handle stays usable after FUSE_FORGET of its node, and with another node's ID, and its inode keeps frozen aliases that bypass the write policy. —
Aliases #1608 FUSE_LINK on an unlinked node links whatever file now occupies its stale path. —
Aliases #1623 Path-based operations on an unlinked or overwritten node act on the file that replaced it at its stale path. —
Aliases #1610 Renaming a path onto itself drops every tracked alias at or below it, so a later capture fails. —
Aliases #1620 Renaming a hard link onto another link of the same file drops the source's alias. —
Policy #1601 Renaming a writable directory moves its denied descendants onto visible, writable paths. —
Policy #1602 A non-exclusive FUSE_CREATE with O_TRUNC at a writable hard link truncates a file that another alias makes read-only. —
Policy #1612 FUSE_MKNOD and RENAME_WHITEOUT create host device nodes, 0:0 whiteouts included. —
Policy #1603 On Windows hosts, case-insensitive lookup and 8.3 short names bypass the share's denied, allowed, and writable paths. —
Policy #1609 On Windows hosts, a handle opened with O_RDONLY | O_TRUNC accepts writes. —
Listing #1611 A microVM READDIRPLUS that fails partway leaks the lookup references of the entries that it had looked up. —
Listing #1622 Unlinking entries while the guest pages through a directory fails READDIRPLUS with ENOENT until the handle closes. —
Listing #1605 A directory that holds a btrfs subvolume root or snapshot placeholder, whose d_ino differs from its st_ino, fails READDIRPLUS with EIO. —
Listing #1634 A child entry that dedups onto the listed directory's own node rewrites the directory's path, and the listing continues inside the child. —
Listing #1613 Directory listings are bounded per handle at run time but in aggregate only at save, so a guest can make a capture fail. —
Aggregate #1598 READDIR on the synthetic root reserves the guest's buffer size, up to 4 GiB, infallibly. —
Aggregate #1617 The synthetic root answers a buffer that fits no entry with an empty reply, which means end of directory, instead of EINVAL. —
Aggregate #1624 FUSE_FSYNCDIR on the synthetic root's handle fails with EBADF. —
Aggregate #1627 HandleMap hands out u64::MAX, the synthetic root's handle, and a saved state that holds it fails to restore. —
Aggregate #1632 The synthetic root's st_nlink counts single-file children as subdirectories. —
Aggregate #1614 A single-file child whose host file name holds : or \ attaches, but every guest lookup of it fails with EINVAL. —
Aggregate #1618 A single-file child named by a bare relative path or a symlink passes validation but fails to attach. —
Credentials #1600 lxutil::with_fs_identity keeps the thread's unmapped supplementary groups when the caller's GID is overflowgid. —
Credentials #1606 Where a user namespace permits setgroups, with_fs_identity restores the thread's unmapped groups as overflowgid: the VMM aborts if that GID is unmapped, and the thread keeps the wrong groups if it is mapped. —

Order. No child blocks another.

Notes.

Activity

  1. 12 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: openvmmInitial title-keyword triage suggestion

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions