Repository navigation
Description
Summary
VirtioFsInode::lookup and VirtioFsInode::inc_lookup increment lookup_count with AtomicU64::fetch_add(1, Ordering::AcqRel), which uses wrapping arithmetic at u64::MAX. When an inode's lookup_count is u64::MAX — reachable directly via microVM saved-state restore without 2^64 live requests — one additional FUSE_LOOKUP, FUSE_READDIRPLUS, or FUSE_LINK wraps lookup_count to 0, allowing the next FUSE_FORGET to evict the still-referenced inode from InodeMap. Found by formal verification.
Root Cause
In vm/devices/virtio/virtiofs/src/inode.rs, both VirtioFsInode::lookup and VirtioFsInode::inc_lookup use fetch_add(1, Ordering::AcqRel) rather than saturating addition, even though VirtioFsInode::forget immediately below already uses AtomicU64::update with saturating_sub:
/// Increments the lookup count.
pub fn lookup(&self, new_path: PathBuf) {
self.lookup_count.fetch_add(1, Ordering::AcqRel);
self.aliases.write().insert(new_path.clone());
let mut path = self.path.write();
*path = new_path;
}
/// Increments the lookup count without updating the path.
///
/// This is used when returning an existing inode in a FUSE reply (e.g., for hard links)
/// where the kernel will track the reference and later send a forget.
pub fn inc_lookup(&self) {
self.lookup_count.fetch_add(1, Ordering::AcqRel);
}In microVM mode, validate_microvm_state accepts any SavedInode with inode.lookup_count != 0, including u64::MAX, and restores it verbatim into VirtioFsInode::lookup_count.
Consequence
Once lookup_count wraps from u64::MAX to 0, the inode remains in InodeMap with a zero reference count until any FUSE_FORGET(node_id, n) arrives. At that point, Fuse::forget computes 0u64.saturating_sub(n) == 0 and removes the node from InodeMap while the guest still holds active FUSE references to node_id. Subsequent guest operations on node_id fail with EINVAL (request for unknown inode), and in microVM mode save_microvm_state also fails if an open handle still points to the evicted inode (open handle refers to an untracked inode).
Reproduction
- Create a temporary directory containing a file
"f", instantiateVirtioFs::new(dir.path(), None), and look up"f"once to obtainnode_id. - Set that inode's
lookup_counttou64::MAX(simulating a restoredSavedInodewithlookup_count: u64::MAXor cumulative lookups). - Look up
"f"a second time (or callinode.inc_lookup()).lookup_countwraps fromu64::MAXto0. - Call
fs.forget(node_id, 1)and thenfs.get_attronnode_id.forgetevictsnode_idfromInodeMap, andget_attrfails withlx::Error::EINVAL.
Related: #1627.
Activity
tangruize commentedon Nov 15, 2026
Suggested Fix
Update
VirtioFsInode::lookupandVirtioFsInode::inc_lookupto useself.lookup_count.update(Ordering::AcqRel, Ordering::Acquire, |count| count.saturating_add(1)), matching the atomicupdatepattern already used inVirtioFsInode::forget. Saturating atu64::MAXensures an inode at the maximum representable reference count stays pinned rather than wrapping to zero and being prematurely evicted.Patch against OpenVMM
9d64daad3cbe14fb0591081b73c6c9648e18d0fb. Save the contents below asfix.patchand rungit apply fix.patch.fix.patch