Repository navigation
Fix official CI by replacing AnyIO in generator cleanup tests - #333
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change adding anyio to CI test tooling.
No open issues 🎉
What changed in this PR
Fixes the official CI test-collection failure by installing anyio as test tooling, while preserving runtime dependency resolution through built wheels.
Changes:
- Adds
anyioto the pipeline’s tooling installation. - Updates the dependency comment to include
anyio; no SDK dependencies or behavior change.
| File | Description |
|---|---|
eng/templates/build.yml |
Installs anyio for tests and updates the accompanying comment. |
Review effort: Balanced
andystaples
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Bernd Verst (berndverst)
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Official pipeline run failed during core test collection because the generator-cleanup tests import
anyio, which the official build does not install.Replace the test's
anyio.create_task_group()context with Python 3.11's standard-libraryasyncio.TaskGroupand removeanyiofrom the development requirements. Preserve the existing cancellation, asynchronous-generator cleanup, and resource-release assertions for both direct and thread-pool execution.No additional pipeline dependency is needed. Runtime dependencies continue to be resolved through the built wheels, preserving checks for missing package dependency declarations. SDK behavior is unchanged.