Repository navigation
Centralize development dependencies in pyproject.toml groups - #334
Open
andystaples wants to merge 2 commits into
Open
andystaples wants to merge 2 commits into
andystaples wants to merge 2 commits into
Conversation
Share test tooling between Nox and the official pipeline while preserving runtime dependency resolution from built wheels. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the consolidation of development and CI tooling into shared dependency groups.
No open issues 🎉
What changed in this PR
Centralizes development and CI tooling in root pyproject.toml dependency groups, reducing dependency drift between local checks and the official build. Runtime dependencies remain in package metadata and are resolved from built wheels in official CI.
Changes:
- Adds focused tooling groups and an aggregate
devgroup, replacing root requirements files. - Updates Nox, GitHub Actions, the official pipeline, and Makefile to use groups with pip 25.1 or later.
- Updates contributor documentation while leaving sample and Function app requirements unchanged.
| File | Description |
|---|---|
requirements.txt |
Removes the legacy development dependency list. |
pyproject.toml |
Defines shared development and CI dependency groups. |
noxfile.py |
Installs session tooling through shared groups. |
Makefile |
Uses the dev group and editable package installs. |
eng/templates/build.yml |
Uses shared build, lint, and test groups while preserving wheel-based runtime validation. |
docs/development.md |
Documents group-based setup and dependency ownership. |
dev-requirements.txt |
Removes the legacy tooling dependency list. |
.github/workflows/typecheck.yml |
Installs Nox through its dependency group. |
.github/workflows/durabletask.yml |
Updates core CI to group-based Nox installation. |
.github/workflows/durabletask-azuremanaged.yml |
Updates Azure Managed CI to group-based Nox installation. |
.github/workflows/durabletask-azurefunctions.yml |
Updates Functions CI to group-based Nox installation. |
.github/copilot-instructions.md |
Updates tooling installation guidance and dependency references. |
Review effort: Balanced
Resolve shared groups through nox.project helpers instead of upgrading pip in each session. Require the Nox release that introduced the group helper. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move repository development and CI tooling from the root requirements files and hard-coded install lists into PEP 735
[dependency-groups]in the rootpyproject.toml.testgroup between Nox sessions and the official build so new test dependencies do not require a separate pipeline update.devgroup.Runtime dependencies and public extras remain in package metadata. The official build continues to resolve SDK runtime dependencies from built wheels rather than a preinstalled development environment. Sample and Function app requirements files remain unchanged.
Relates to #333.