P3059R2: Making user-defined constructors of view iterators/sentinels private.

stl/debugger/STL.natvis

@@ -1851,6 +1851,14 @@ SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
     </Expand>
   </Type>
 
+  <Type Name="std::ranges::iota_view&lt;*,*&gt;::_Sentinel&lt;*&gt;">
+    <AlternativeType Name="std::ranges::_Iotinel&lt;*&gt;"/>
+    <DisplayString>{&amp;_Last, na}</DisplayString>
+    <Expand>
+      <Item Name="[bound]">_Last</Item>
+    </Expand>
+  </Type>
+
   <Type Name="std::ranges::repeat_view&lt;*,*&gt;">
     <DisplayString>[{_Value._Val} x {_Bound}]</DisplayString>
     <Expand>
@@ -1911,13 +1919,6 @@ SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
     </Expand>
   </Type>
 
-  <Type Name="std::ranges::_Iotinel&lt;*&gt;">
-    <DisplayString>{&amp;_Last,na}</DisplayString>
-    <Expand>
-      <Item Name="[bound]">_Last</Item>
-    </Expand>
-  </Type>
-
   <Type Name="std::ranges::take_while_view&lt;*&gt;">
     <AlternativeType Name="std::ranges::drop_while_view&lt;*&gt;"/>
     <AlternativeType Name="std::ranges::drop_view&lt;*&gt;"/>

stl/inc/__msvc_ranges_to.hpp

@@ -672,6 +672,17 @@ namespace ranges {
             using _Parent_t = _Maybe_const<_Const, transform_view>;
             using _Base     = _Maybe_const<_Const, _Vw>;
 
+            constexpr _Iterator(_Parent_t& _Parent_, iterator_t<_Base> _Current_)
+                noexcept(is_nothrow_move_constructible_v<iterator_t<_Base>>) // strengthened
+                : _Current{_STD move(_Current_)}, _Parent{_STD addressof(_Parent_)} {
+#if _ITERATOR_DEBUG_LEVEL != 0
+                _STD _Adl_verify_range(_Current, _RANGES end(_Parent_._Range));
+                if constexpr (forward_range<_Base>) {
+                    _STD _Adl_verify_range(_RANGES begin(_Parent_._Range), _Current);
+                }
+#endif // _ITERATOR_DEBUG_LEVEL != 0
+            }
+
             iterator_t<_Base> _Current{};
             _Parent_t* _Parent{};
 
@@ -699,17 +710,6 @@ namespace ranges {
                 requires default_initializable<iterator_t<_Base>>
             = default;
 
-            constexpr _Iterator(_Parent_t& _Parent_, iterator_t<_Base> _Current_)
-                noexcept(is_nothrow_move_constructible_v<iterator_t<_Base>>) // strengthened
-                : _Current{_STD move(_Current_)}, _Parent{_STD addressof(_Parent_)} {
-#if _ITERATOR_DEBUG_LEVEL != 0
-                _STD _Adl_verify_range(_Current, _RANGES end(_Parent_._Range));
-                if constexpr (forward_range<_Base>) {
-                    _STD _Adl_verify_range(_RANGES begin(_Parent_._Range), _Current);
-                }
-#endif // _ITERATOR_DEBUG_LEVEL != 0
-            }
-
             constexpr _Iterator(_Iterator<!_Const> _It)
                 noexcept(is_nothrow_constructible_v<iterator_t<_Base>, iterator_t<_Vw>>) // strengthened
                 requires _Const && convertible_to<iterator_t<_Vw>, iterator_t<_Base>>
@@ -923,6 +923,10 @@ namespace ranges {
             template <bool _OtherConst>
             using _Maybe_const_iter = iterator_t<_Maybe_const<_OtherConst, _Vw>>;
 
+            constexpr explicit _Sentinel(sentinel_t<_Base> _Last_)
+                noexcept(is_nothrow_move_constructible_v<sentinel_t<_Base>>) // strengthened
+                : _Last(_STD move(_Last_)) {}
+
             sentinel_t<_Base> _Last{};
 
             template <bool _OtherConst>
@@ -937,9 +941,6 @@ namespace ranges {
 
         public:
             _Sentinel() = default;
-            constexpr explicit _Sentinel(sentinel_t<_Base> _Last_)
-                noexcept(is_nothrow_move_constructible_v<sentinel_t<_Base>>) // strengthened
-                : _Last(_STD move(_Last_)) {}
 
             constexpr _Sentinel(_Sentinel<!_Const> _Se)
                 noexcept(is_nothrow_constructible_v<sentinel_t<_Base>, sentinel_t<_Vw>>) // strengthened