P3059R2: Making user-defined constructors of view iterators/sentinels private. - #6382

Open

Iskandar Emomzoda (iskandarem) wants to merge 41 commits into

microsoft:mainfrom

iskandarem:unable-view-sentinel-iterator-creation-from-outside

Commits on Aug 1, 2026

filter_view::iterator u-d construtor made private;
Iskandar Emomzoda (iskandarem)
committed
835c6ef
filter_view::iterator u-d sentinel made private;
Iskandar Emomzoda (iskandarem)
committed
1dcbff4
filter_view::iterator/sentinel ud-constructors made private; also made filter_view a friend class to filter_view::iterator/sentinel classes;
Iskandar Emomzoda (iskandarem)
committed
f515edd
basic_istream_view::iterator(iterator, view&) made private; basic_istream_view is friend class now, cause it has to have the access to the private-constructor; test written for that;
Iskandar Emomzoda (iskandarem)
committed
91d1939
transform_view::iterator/sentinel ud-constructors made private; corresponding tests are written;
Iskandar Emomzoda (iskandarem)
committed
769c5e3
take_view::sentinel ud-constructors made private; corresponding tests are written;
Iskandar Emomzoda (iskandarem)
committed
b90b438
take_while_view::sentinel ud-constructors made private; corresponding tests are written;
Iskandar Emomzoda (iskandarem)
committed
0bca681
join_view::sentinel ud-constructors made private; corresponding tests are written;
Iskandar Emomzoda (iskandarem)
committed
91178a1
lazy_split_view::inner- outeriterator u-d constructors made private; friend lazy_split_view added for lazy_split_view to have access
Iskandar Emomzoda (iskandarem)
committed
307cf60
split_view::iterator/sentinel u-d constructors made private; split_view made friend class for sentinel; corresponding tests has been written;
Iskandar Emomzoda (iskandarem)
committed
e2f929c
iota_view Ioterator and Iotinel constructor made private; coressponding tests are written;
Iskandar Emomzoda (iskandarem)
committed
fbe7263
Potential fix for pull request finding

Iskandar Emomzoda (iskandarem)
and
Copilot
committed
850c5ad
env.lst change to use C++20 matrix so the constructors-access is also validate in `/std:c++20`;
Iskandar Emomzoda (iskandarem)
committed
67ff51f
comment updated to reflect the assertions(non-copyable but moveable);
Iskandar Emomzoda (iskandarem)
committed
2f52b64
misspelled word corrected in tests\std\test/lst and in test folder;
Iskandar Emomzoda (iskandarem)
committed
75048ef
comment removed;
Iskandar Emomzoda (iskandarem)
committed
db52818
test lazy_split_view::begin access to iterator;
Iskandar Emomzoda (iskandarem)
committed
aaf5452
comment removed;
Iskandar Emomzoda (iskandarem)
committed
121e94c
wrote not static tests to test normal behavior of views;
Iskandar Emomzoda (iskandarem)
committed
0d3a2da
format rules applied to changed files;
Iskandar Emomzoda (iskandarem)
committed
8446bfd
comments refactored;
Iskandar Emomzoda (iskandarem)
committed
e220fec
extra empty lines removed;
Iskandar Emomzoda (iskandarem)
committed
cc271fa
trailing whitespaces removed;
Iskandar Emomzoda (iskandarem)
committed
968850b
tests removed that were incompatible with P3059R2 change;
Iskandar Emomzoda (iskandarem)
committed
3f62c35
Merge branch 'main' of https://github.com/iskandarem/microsof-stl into unable-view-sentinel-iterator-creation-from-outside
Iskandar Emomzoda (iskandarem)
committed
1cb131a
tests in libcxx that affect p3059r2 marked as failed;
Iskandar Emomzoda (iskandarem)
committed
009379f
format error fixed(trailing whitespace);
Iskandar Emomzoda (iskandarem)
committed
fd0e4e6
expected_result.txt: marked-as-fail-tests sorted;
Iskandar Emomzoda (iskandarem)
committed
3249016
Inner class _Sentinel created to replace _Iotinel in iota_view;
Iskandar Emomzoda (iskandarem)
committed
f652cb7
_Iotinel was removed; _Sentinel was added to STL.natvis;
Iskandar Emomzoda (iskandarem)
committed
f641b24

Commits on Aug 3, 2026

Commits on Aug 4, 2026

update .natvis for nested iota_view template sentinel class;
Iskandar Emomzoda (iskandarem)
committed
5c58dcb

Commits on Aug 7, 2026

standalone _Iotinel natvis entry removed; _Sentinel entry changed to include _Iotinel as AlternativeType;
Iskandar Emomzoda (iskandarem)
committed
d88b318

Commits on Aug 13, 2026

bogus test was fixed in llvm so the test moved to issues reported;
Iskandar Emomzoda (iskandarem)
committed
d212d93