feat(dev-env-setup): v26 — cancel superseded PR CI runs + pin skill sources - #34
Open
mickzijdel wants to merge 2 commits into
Open
mickzijdel wants to merge 2 commits into
mickzijdel wants to merge 2 commits into
Conversation
commit-digest: nateberkopec/dotfiles PR #689 ("Remove code simplifier and
pin skill upstream sources") switched his adapted-skill front matter from
tree/main links to blob/<sha> links, since main is a moving target and a
"source" citation should point at the exact content it was adapted from.
dev-hooks has the same gap in codebase-design, domain-modeling, and grill
(itself merged from three of Nate's skills) — pin all four source links to
mattpocock/skills' current HEAD commit.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016UwqgnJbX8hVF5RmRppVSr
commit-digest: nateberkopec/dotfiles commit 96b0b84 ("Cancel superseded
pull request CI runs") added a concurrency block to his workflows so a
stale push's CI doesn't keep running once a newer push on the same PR has
started. Neither dev-hooks' own CI nor any of the standard's five CI
templates had this — every push to an open PR queued a full run to
completion even when a follow-up push had already superseded it.
Add a top-level `concurrency:` block (grouped by workflow + PR number,
cancel-in-progress gated to the pull_request event only, so a push to main
is never canceled mid-run) to all five CI templates and to this repo's own
ci.yml. Wire a matching `has_ci_concurrency` checker signal, bump
DEV_ENV_VERSION to 26 across the templates and this repo, and add the
v25 -> v26 upgrade-guide section plus test coverage (template content,
checker compliant/needs-upgrade cases).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016UwqgnJbX8hVF5RmRppVSr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent
commit-digestfinds fromnateberkopec/dotfiles, bundled into one PR because this session's branch is fixed to one per repo:feat(dev-env-setup): v26(dev-hooks plugin, minor) — dotfiles commit96b0b84("Cancel superseded pull request CI runs") adds aconcurrency:block so a stale push's CI run is canceled once a newer push on the same PR starts, instead of both runs burning runner minutes to completion. Neither this repo's ownci.ymlnor any of the standard's five CI templates had this. Added a top-levelconcurrency:block (grouped by workflow + PR number,cancel-in-progressgated to thepull_requestevent only — a push tomainis never canceled mid-run) to all five CI templates and to this repo'sci.yml, wired a matchinghas_ci_concurrencychecker signal, bumpedDEV_ENV_VERSIONto 26 across the templates and this repo, and added thev25 → v26upgrade-guide section plus test coverage.fix(thinking-tools)(thinking-tools plugin, patch) — dotfiles PR#689("Remove code simplifier and pin skill upstream sources") switched Nate's adapted-skillsource:front matter fromtree/mainlinks toblob/<sha>links, sincemainis a moving target.codebase-design,domain-modeling, andgrill(merged from three of Nate's skills) had the sametree/maingap — pinned all four source links tomattpocock/skills' current HEAD commit.Test plan
uv run pytest -q— 747 passedbash plugins/dev-hooks/skills/dev-env-setup/scripts/dev_env_check.sh .reportsstatus=compliantat v26 for this repobash -non the edited checker script🤖 Generated with Claude Code
https://claude.ai/code/session_016UwqgnJbX8hVF5RmRppVSr
Generated by Claude Code