Repository navigation
Review/python3.14 fixes - #38
Closed
aportagain wants to merge 11 commits into
Closed
aportagain wants to merge 11 commits into
aportagain wants to merge 11 commits into
Conversation
Maybe just came from string search-and-replace?
Doesn't break anything, but maybe better this way to stay consistent between the boo, int and float lists?
Wrong repo / package ;) Otherwise just says "WARNING: Failed to generate report: No data to report."
Funny colours on github.com, was also wrong in some of the older ones :)
From setup.py. If we decide to (still) keep both, we'd have to specify setuptools as the build-system / build-backend... I think?
Just to be consistent with the one in pyproject.toml :)
Trying to support Python 3.11 to 3.14 results in different default time resolutions (microsecond vs. nanosecond).
Member
Author
|
Oh, and GitHub-native PR "stacks" are new to me... didn't tick that box now, but feel free to change / use that if you think it makes sense... :) |
Member
Author
|
I think Simon's now already made all the substantial changes in his corresponding PR / branch, so I'm gonna close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Simon,
finally found time to look at your PR #37, thanks heaps, looks good overall!
I've made a few small changes, and then the main thing tried to support 3.11 to 3.14 for the dependency constraints, tox setup and tests... I know 3.11 is pretty old now, but might ease soft / partial upgrades of other operational stuff running 3.11, and I'd say is still in line with the ex-MetOcean CoP / guidelines / whatever ("For requires-python, set the lower bound as low as practical, as long as it doesn’t introduce issues. Realistically, supporting more than about four Python versions tends to become painful.", MOS CoP wiki page).
Have a look, maybe it makes sense, maybe I broke something else now... happy to chat next week or whenever you have time :)