Repository navigation
Upgrade/python3.14 - #37
Merged
Merged
Conversation
Closed
aportagain
approved these changes
Sep 17, 2026
aportagain
left a comment
aportagain
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks Simon!
Could give it a patch version bump now then?
You didn't merge my corresponding feedback PR, but that's pretty much all included here now, so that one can be deleted then, right? #38
Contributor
Author
Yes, I incorporated it manually. Mostly to in a way understand your thought process of the review, and include some tiny changes to your changes as well. I'll bump the version and then merge this one in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
todo