Repository navigation
fix: generated create routes drop server-owned input across ports (1.2.x security) - #568
Merged
Merged
Conversation
… security) Python 1.2.1 stopped its generated routes from handing raw request input to the repository. The same audit found related create-path holes in 1.2.0 in the other four ports; this closes each in its own idiom. Server-owned values are dropped silently, never answered with 400. - Java (codegen-spring): create strips a generated id, readOnly and derived fields; a TPH per-subtype create also strips the body discriminator and sibling-subtype fields. - Kotlin (codegen-kotlin): create skips readOnly/derived columns; a TPH per-subtype create writes only the route subtype's own columns. - C# (MetaObjects.Codegen): every readOnly property shape gets a private setter; create resets a generated id, the TPH discriminator and M:N navigations before Add. - TypeScript (codegen-ts): the update schema omits primary-key fields, so PUT/PATCH can no longer re-key a row with an assigned key. Proof: new shared api-contract scenarios (core + TPH input-server-owned, TPH foreign discriminator) and a readOnly `role` field in secret-fields, run in every port's generated lane and the reference lanes; a new `unset` assertion key in all five harnesses. In-memory test repositories now store what they are handed, so the scenarios fail on the 1.2.0 generators. Proposed versions (not published): npm 1.2.2, NuGet 1.2.2, Maven 8.2.2; PyPI unchanged at 1.2.1. metamodelVersion unchanged.
…ed create Pre-gate review follow-ups to the 1.2.x create-input patch: - C#: the required-key check skips readOnly fields (the private setter never binds them), and create validation ignores a violation naming only a @required readOnly member, as Java's SERVER_OWNED_ON_CREATE does. - Java: the create-validation server-owned set covers every DTO component, so a nulled readOnly or derived value-object column no longer 400s. - TypeScript: drop the now-dead PK guard in the update-schema nullable arm and list the PK rule in updateSchemaFields' doc comment.
dmealing
added a commit
that referenced
this pull request
Nov 14, 2026
…rt (#580) * fix(python): pass only validated input to the repository in generated routes (#566) * fix(python): generated routes hand the repository only the validated input (1.2.1) The generated FastAPI create, PATCH and PUT handlers validated the body against <Entity>Create / <Entity>Patch and then passed the RAW body to the repository. Pydantic ignores undeclared keys and the input models leave out server-owned fields, so a client-sent id, a readOnly field and a made-up field such as isAdmin all reached the write. Security fix. Each handler (plain and TPH per-subtype) now rebinds dto to the keys the input model validated, at every depth, before any repository call, as the TypeScript routes do. Undeclared and non-settable keys are dropped silently, never 400'd, so a client sending an extra harmless field keeps working; values stay the body's own, so repositories see the same value types as in 1.2.0. Python package version 1.2.1 only; CHANGELOG entry under Security. Regression gate: tests/integration/test_generated_router_validated_input.py. * no-mistakes(document): python routes pass only validated input * no-mistakes(lint): regenerate showcase site payload for PyPI 1.2.1 * fix(codegen): generated routes drop server-owned and undeclared input in every port An audit after the Python 1.2.1 fix found the same request-input hole in the other ports' generated create handlers. Each port now drops, silently and before the write, a server-generated key, readOnly and derived fields, and on a TPH per-subtype route the discriminator and sibling-subtype columns; undeclared keys are dropped everywhere. - Python: forward-port of the 1.2.1 fix; TPH create drops a body discriminator. - Java: create nulls the dropped DTO components; DTOs ignore unknown properties. - Kotlin: create writes only settable columns; entity classes ignore unknown keys. - C#: create resets the generated key, discriminator and M:N navigations; every readOnly property gets a private setter. - TypeScript: an assigned primary key leaves the update schema. Shared api-contract scenarios input-server-owned-dropped (core) and tph-input-server-owned-dropped, a readOnly column in secret-fields, and an `absent` assertion in every runner gate it. * feat(codegen): a validation 400 lists every issue in every port The same model answered a failed create or update differently by language: TypeScript listed each problem, while C#, Java, Kotlin and Python returned a bare {"error":"validation"}. Every port's generated routes and its hand-rolled reference servers now answer 400 {"error":"validation","issues":[{code,path, message}]} with every failure, codes in Zod's vocabulary and path as an array of wire names. - C#: ValidationIssues runtime file (ejected with routes); create reads the body itself so an unbindable body lists its issue; PATCH collects instead of returning on the first failure. - Java: ValidationIssues runtime helper; a Patch binds every field before it throws. Kotlin: per-package MetaValidationIssues.kt; create lists every absent required value. - Python: every Pydantic error mapped in constraint_errors; decimal failures carry their wire path. Shared scenarios validation-lists-issues and tph-validation-lists-issues, with a new `issues` assertion in every runner, gate it in both lanes. * feat(api): a page size for generated list routes, api.pagination (TypeScript) List endpoints had no hard cap: a TypeScript or C# list with no `limit` returned the whole table and `?limit=100000` was accepted everywhere. A project can now set `"api": { "pagination": { "defaultLimit": N, "maxLimit": M } }` in .metaobjects/config.json: a generated entity or projection list with no `limit` answers the default page, and a `limit` above the cap answers 400 {"error":"limit_too_large","maxLimit":M}. Reports keep their own row cap and opaque views their 1000. - sdk reads and validates the block; the loaded root carries it (apiPaginationOf), as it carries the wire format. - runtime-ts mounts take a `pagination` option (pageLimit); the packaged and reference Fastify and Hono routes emit it. Owned copies re-synced. - meta init writes 50 / 1000 for a new project; `--force` over an existing config does not add it. A project without the setting behaves as before, and meta verify advises (rule unbounded-list-pages) when routes are wired. - New api-contract `pagination/` sub-corpus, run in the TypeScript generated lane. The C#, Java, Kotlin and Python routes do not read it yet: their REST generators are under the non-TS freeze, pending that ruling. A config key, not vocabulary: metamodelVersion does not move. * feat(api): api.pagination in every port, and api.unknownFields (reject by default) api.pagination (default page size and hard cap on generated list routes) now reaches the C#, Java, Kotlin and Python generators as well as TypeScript: no limit answers the default page, a limit over the cap is 400 limit_too_large. No setting keeps today's behaviour. verify advises when routes are generated without it (TypeScript, Python, Java/Kotlin, and C# under verify --codegen). api.unknownFields (reject | drop, default reject): a generated create, PUT or PATCH body carrying a key the entity does not declare answers 400 {"error":"unknown_fields","fields":[...]} in every port, before validation, and writes nothing. drop keeps the old silent behaviour. Declared server-owned keys (id, readOnly, @autoset, writeOnce on update, the TPH discriminator, a sibling subtype's column) are still dropped, not refused, so a client echoing back a row keeps working. Java and Kotlin check the raw body, so the answer does not depend on the host's Jackson mapper; a test proves it under both FAIL_ON_UNKNOWN_PROPERTIES values. The pagination sub-corpus becomes api-settings/ and runs in every port's generated lane; the core and tph corpora gain reject scenarios. meta init writes both settings into a fresh config. * chore(showcase): regenerate for api.unknownFields * fix(api): code-point order for unknown_fields, every distinct validation issue, a negative limit refused under api.pagination - unknown_fields lists keys in code-point order in every port (TypeScript and C# sorted by UTF-16 code unit, which put a key outside the BMP first). - A validation 400 keeps two distinct failures of one rule kind on one field (Python and C# de-duplicated on path and code); a type error still lists once. - Under api.pagination a negative limit answers 400 pagination.invalid_value in every port instead of reaching the store (SQLite reads LIMIT -1 as no limit). New api-settings/limit-negative scenario. - Python validated-input tests follow api.unknownFields; advanced-modeling example regenerated; C# routes generator header names the current contract. * fix: generated create routes drop server-owned input across ports (1.2.x security) (#568) * fix: generated create routes store only client-settable fields (1.2.x security) Python 1.2.1 stopped its generated routes from handing raw request input to the repository. The same audit found related create-path holes in 1.2.0 in the other four ports; this closes each in its own idiom. Server-owned values are dropped silently, never answered with 400. - Java (codegen-spring): create strips a generated id, readOnly and derived fields; a TPH per-subtype create also strips the body discriminator and sibling-subtype fields. - Kotlin (codegen-kotlin): create skips readOnly/derived columns; a TPH per-subtype create writes only the route subtype's own columns. - C# (MetaObjects.Codegen): every readOnly property shape gets a private setter; create resets a generated id, the TPH discriminator and M:N navigations before Add. - TypeScript (codegen-ts): the update schema omits primary-key fields, so PUT/PATCH can no longer re-key a row with an assigned key. Proof: new shared api-contract scenarios (core + TPH input-server-owned, TPH foreign discriminator) and a readOnly `role` field in secret-fields, run in every port's generated lane and the reference lanes; a new `unset` assertion key in all five harnesses. In-memory test repositories now store what they are handed, so the scenarios fail on the 1.2.0 generators. Proposed versions (not published): npm 1.2.2, NuGet 1.2.2, Maven 8.2.2; PyPI unchanged at 1.2.1. metamodelVersion unchanged. * fix: keep a @required readOnly field creatable in C# and Java generated create Pre-gate review follow-ups to the 1.2.x create-input patch: - C#: the required-key check skips readOnly fields (the private setter never binds them), and create validation ignores a violation naming only a @required readOnly member, as Java's SERVER_OWNED_ON_CREATE does. - Java: the create-validation server-owned set covers every DTO component, so a nulled readOnly or derived value-object column no longer 400s. - TypeScript: drop the now-dead PK guard in the update-schema nullable arm and list the PK rule in updateSchemaFields' doc comment. * no-mistakes(review): apply reviewer inline fixes * no-mistakes(review): Kotlin readOnly create fix + C# reset skip * no-mistakes(document): docs: finish stale corpus counts from input fix * fix(cli): prune emptied skill directories after a --skills-dir move; install every module the Kotlin integration lane needs meta init --refresh-docs --skills-dir <new> removed the untouched skill files at the old path but left their directories behind, which read as the old copy still being there. Walk up from each pruned file and remove the directories it left empty, stopping at the first that still holds anything and never removing the skills directory itself. scripts/integration-test.sh kotlin installed only metadata and codegen-kotlin, so on an .m2 without the other metaobjects artifacts integration-tests-kotlin failed to resolve core-spring and om, and codegen-kotlin-exposed1x-check metadata-ktx. * test(render): hold the email helper in the runtime-drift corpus case Every generated render path in the five ports already raises ERR_VAR_NOT_ON_PAYLOAD for a template variable not on the payload (1.3.0, #520), and runtime-drift/ held the document and prompt helpers. The @kind: email helper was not in the case. Add WelcomeEmail plus email-subject/, email-html/ and email-text/ drift directories, one drifted part each, and check every part raises in the TS, Python, C#, Java and Kotlin runners. * feat(init): dotnet meta init and metaobjects init write the api block TypeScript meta init writes A new project gets api.pagination 50/1000 and api.unknownFields reject in .metaobjects/config.json from every port's init; an existing config is never edited. * feat(init): dotnet meta init and metaobjects init also write migrate.foreignKeyIndexes and verify.handEdits The same new-project keys TypeScript meta init writes since #577. * feat(api): drop undeclared value-object members everywhere and share the api config cases - New jsonb scenario jsonb-nested-undeclared-key-dropped: api.unknownFields judges the top level only, so a member a value object does not declare is dropped on create and PATCH and never stored, while the open jsonb bag keeps every key. The reference servers in every port drop such members; the Java generated value-object record now carries @JsonIgnoreProperties(ignoreUnknown = true) (it answered 400 invalid_type). - New shared config corpus api-settings/config-blocks.json (valid and refused api blocks), run by the TypeScript, C#, Java and Python config readers. A page size is a positive whole number however JSON spells it, at most 2147483647: C# now reads 50.0, TypeScript and Python refuse anything above the int32 range. - CHANGELOG: an Upgrading section (api.unknownFields reject as the one deliberate default change, the C# readOnly private setter), init parity across ports, the nested-member rule. Counts, READMEs, api-contract.md and the migration guide updated; showcase Java regenerated. * fix(api): close the code-review findings on the input and page-size work - C#: with api.pagination set, `limit=0` served the default page; it is now a page of zero rows, as in every other port. New shared scenario api-settings/limit-zero (all five ports green). - C#: the unknown-field check matches a key the way the route binds the body (the app's System.Text.Json options; the ASP.NET web default ignores case), so `Title` is the declared `title`, not a 400. The verify advisory matches the routes generator by type or exact name, not by a "routes" substring. - Python: a rejected decimal's text is no longer echoed into the 400 issue message; the unbounded-list-pages advisory fires only when the routes generator is wired; the dead _DECIMAL_COERCE constant is gone. - Java: UnreadableBody's Javadoc describes the issues envelope it returns. - Docs: M:N traversal routes take no limit and are not paged by api.pagination (stated as the boundary); the C# port doc no longer says dotnet meta init writes no config. Counts updated. * refactor: read the project config once in the Maven mojo; drop a no-op path coercion in Python issues Simplify pass: AbstractMetaDataMojo maps its four project settings from one read of .metaobjects/config.json, and pydantic_issues copies loc as-is (its entries are already int or str). * no-mistakes(review): Scope ignoreUnknown to request bodies; fix review items * no-mistakes(review): Drop discriminator on Python TPH update; fix scenario text * no-mistakes(review): apply reviewer inline fixes * no-mistakes(review): Fix doc counts, dead guard, stale comments, vacuous assertion * no-mistakes(review): apply reviewer inline fixes * no-mistakes(review): Fix stale routes comment in C# api-settings factory * no-mistakes(review): Fix stale eject docs, vacuous C# check, assertion messages * no-mistakes(review): Refuse non-numeric C# page bounds with 400 * no-mistakes(review): Refuse out-of-range or negative C# offset * no-mistakes(review): Drop source-grepping Python router tests * no-mistakes(review): apply reviewer inline fixes * test(ts): re-sync the owned zod-validators copy after the pkFields reference change The input-handling change edited the codegen-ts reference source but not the owned copy under test-generators, so cli/test/owned-copies-current.test.ts (the 'owned copies are what meta eject writes' gate) failed: the copy on disk kept the pre-change update-shape text. bun scripts/sync-owned-template-copies.ts re-synced 1 of 128 owned copies; no other copy drifted. * no-mistakes(test): Validate re-synced zod-validators owned copy * no-mistakes(test): apply changes made during test validation * no-mistakes(document): Correct init config docs for C# and Python * test(kotlin): expect table-qualified columns in the TPH create autoSet tests The TPH per-subtype create now writes every column through the table object (it[AuthTable.autoCreatedAt]), so a column named body, issues or unknownKeys cannot be shadowed by the handler's locals. Two KotlinAutoSetStampingTest cases still asserted the unqualified form and failed the java-slow lane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The Python 1.2.1 patch closed a hole where the generated routes handed the repository raw request input. An audit of the other four ports found related holes in 1.2.0. This PR closes them on
release/1.2, each in that port's own idiom:codegen-spring). Create forwarded a clientidandreadOnlyvalues to the repository. A TPH per-subtype create also forwarded the body's discriminator and a sibling subtype's columns.codegen-kotlin). Create wrotereadOnlycolumns. A TPH per-subtype create wrote a sibling subtype's columns.MetaObjects.Codegen). Create bound the EF entity, so a clientidwas inserted. A TPH create stored the body's discriminator (a POST to the Bridge route created a Copay row). A TPH subtype'sreadOnlyfield and an M:N navigation graph were written.codegen-ts).<Entity>UpdateSchemakept an assigned primary key, so a PUT or PATCH could re-key the row.Every value above is now dropped silently, never answered with a 400. A key the model does not declare is still dropped silently in TypeScript, C# and Python.
Per-port before and after (1.2.0 → this PR)
id(generated key)readOnlyfieldAddPUT and PATCH were otherwise already safe in every port.
How it is proved
New shared api-contract scenarios. Each scenario sends a client
id, areadOnlyfield, a foreign discriminator and an undeclared key, then asserts that none of them was stored.scenarios/input-server-owned-dropped.yaml(core): POST, PATCH and PUT with a clientidandisAdmin. Asserts the id was not stored (GET/999returns 404), the row keeps its id, and thewriteOncefield is unchanged.tph/scenarios/tph-input-server-owned-dropped.yaml: a clientid, a sibling subtype'scopayAmountandisAdminsent to the Bridge route. No Copay row matches.tph/scenarios/tph-input-foreign-discriminator-dropped.yaml:type: "Copay"sent to the Bridge route on create and on PATCH. The row stays a Bridge.secret-fields/: gains areadOnlyrolefield.write-ignores-excludedsendsrole: "admin"on create, PATCH and PUT and asserts it was not stored.unset: each listed key is missing ornull. Ports differ on whether an unset column is echoed asnull, so either counts.Lanes run:
In-memory test repositories now store what they are handed. This applies to the Java Author, Account and Auth repositories: they keep a forwarded
idand discriminator. The scenarios therefore fail on the unfixed generators. I checked this by running them against the 1.2.0 generator sources:/999returned 200.row.type=Copay, andcopayAmountwas stored.role=admin.copayAmount, secret-fieldsrole)./999, TPH/999, TPHtype=Copay).Reference-server fixes. Two reference servers stored what they were handed, so they now follow the same contract:
Codegen unit tests cover the cases the shared models do not declare:
readOnlyfield: C#ServerOwnedCreateInputTests, JavaSpringServerOwnedInputCodegenTest, KotlinKotlinServerOwnedInputTest.ServerOwnedCreateInputTests).zod-validators.test.ts).Pre-gate review follow-ups. An independent review of this branch found two edge cases the patch widened, both now fixed with a codegen test:
@requiredreadOnlyfield was still demanded on the create body and held to its[Required]. Now that every readOnly shape has a private setter, such an entity could not be created. The required-key check now skips readOnly fields, and create validation ignores a violation that names only one of them, as Java already did.@requiredreadOnlyvalue-object column, nulled by the new strip, would have made every POST a 400. The filter now covers every DTO component.Gate review fixes (no-mistakes, round 1).
@requiredreadOnlyor derived field on a plain entity is now server-owned on create, like the generated key and@autoSetfields: the property is nullable, defaults to null and has no@NotNull.KotlinServerOwnedCreateBindTestbinds and validates a create body with the field present and with it omitted.readOnly. Its private setter would make the assignment a compile error, and the value is already the default. A Roslyn compile test covers that model.docs/features/generated-mutations.mdnow notes that Kotlin's create never binds a declared key.Not changed in this patch
ObjectMapper. Spring Boot's default (FAIL_ON_UNKNOWN_PROPERTIESoff) drops the key. A plainObjectMapperanswers400 {"error":"validation","field":"isAdmin"}. This patch does not change that. The Java and Kotlin test harnesses now configure their mappers as Spring Boot does, with a comment saying so.tph-input-foreign-discriminator-droppedwith a reason, recorded inserver/python/src/metaobjects/codegen/KNOWN_GAPS.md(excluded from the wheel).Proposed versions (not published, not tagged)
@metaobjectsdev/*, lockstep)codegen-tschanged; 1.2.1 was spent by the Python-only releaseMetaObjects.Codegenchangedcodegen-spring,codegen-kotlinchanged (reactor moves together)KNOWN_GAPS.mdmetamodelVersionis unchanged. The CHANGELOG has a Security entry under[Unreleased]. The showcase is regenerated: only the C# route changed. The site payload and thedocs/llms/mirrors now show the proposed versions (the mirror gate requires them to match the package versions); PyPI stays at 1.2.1 there.Validation
One no-mistakes run (
01M7B1CT5QYHVNKK136QWSBCKJ), with one review fix round. GitHub Actions checks run on this PR.Re-ran the configured baseline command (ci-local ts-fast+ts-unit) at the target, then drove the change live per port: the shared api-contract corpora (write-through, tph, secret-fields with the new readOnly
role, and the three new input-security scenarios) were executed over HTTP against each port's generated server — Java/Kotlin embedded Tomcat, C# ASP.NET hosts, TS Fastify over a real Postgres sidecar, Python FastAPI — with every port passing the attacker-payload scenarios (client-generated-key id, undeclared keys, sibling-subtype columns, foreign body discriminator, readOnly role) and Python showing only its documented tph-input-foreign-discriminator-dropped skip (400 instead of silent drop; KNOWN_GAPS.md, nothing stored). The TypeScript assigned-PK re-key hole got its own live regression proof: a drive of the emitted validators fails at base (forged keycode: "EVIL"survives UpdateSchema) and passes at target. Generator-level suites for the new guards (Java SpringServerOwnedInputCodegenTest, Kotlin ServerOwned bind/input tests, C# ServerOwnedCreateInputTests) ran green, as did the full C# integration suite (395), C# unit projects (3902 total), JVM codegen unit modules, Python integration (439), and the repo gates lane. Not run: the Java reactor modules outside codegen-spring/codegen-kotlin (pom-bump-only in this change) and the cube live check (reporting surface untouched). One setup issue encountered and worked around, not caused by this change: standalone scripts/integration-test.sh kotlin misses core-spring in .m2 (finding 1). Verdict supported: every derived scenario passed against the real product.Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
server/java/codegen-kotlin/src/main/kotlin/com/metaobjects/generator/kotlin/KotlinSpringControllerGenerator.kt:536- Kotlin is the one port where commit 8e7a84c's invariant — a server-owned field must not make the create body fail — is still violated. A @required @mutability:readOnly field on a vanilla entity: the data-class property stays non-null with @field:NotNull (KotlinEntityGenerator.kt:282-283 —isServerOwnedOnCreatecovers only generated PK and @autoset, KotlinGenUtil.kt:666-670), so a create body omitting the field fails Jackson binding → 400, and a body including it binds and validates, then the new SECURITY skip at KotlinSpringControllerGenerator.kt:536 drops the column from the insert → NOT NULL violation → 500. Either way the entity becomes UNCREATABLE after this patch, where before it stored the client value; C# (RequiredReadOnlyProps, RoutesGenerator.cs:767) and Java (SERVER_OWNED_ON_CREATE / isNonSettableOnCreate, SpringControllerGenerator.java:1659-1664, 1605-1613) got the counterpart fix in the same patch series, and TS (insertSchemaFields drops readOnly) and Python (1.2.1) are unaffected. TPH is immune (the union data class is all-nullable). Fix: include readOnly/derived in KotlinGenUtil.isServerOwnedOnCreate (or in the KotlinEntityGenerator nullable-relaxation set) so the property is nullable, default-null and annotation-free, matching the existing generated-key/autoSet relaxation.server/csharp/MetaObjects.Codegen/Generators/RoutesGenerator.cs:1116- ServerOwnedCreateResets emitsinput.<Prop> = default!;for the generated PK (RoutesGenerator.cs:1116) and the TPH discriminator (RoutesGenerator.cs:1117), but EntityGenerator.cs:1675 (SetterFor) now gives a @mutability:readOnly field a PRIVATE setter on every property shape. A legal model that marks the increment/uuid key field or the discriminator field readOnly (a natural way to state "the server owns this") makes the generated route assign a private-setter property → CS0122: the adopter's build fails on generated code, on both the vanilla create (key reset) and every TPH per-subtype create (discriminator reset, RoutesGenerator.cs:1519). The reset is also redundant in exactly those cases — System.Text.Json never binds a private setter, so the value is already default. Fix: skip emitting the reset line when the underlying field IsReadOnlyMutability (the discriminator field istph.DiscriminatorFieldon the base). Sibling site: the same private-setter collision cannot occur for the M:N navigation resets — M2mNavProperty (EntityGenerator.cs:513) always emits a public setter.docs/features/generated-mutations.md:74- The new "Create stores only what a client may set, in every port" paragraph stated "An assigned key (no @generation) is the caller's on create" as a cross-port rule, but Kotlin's generated create never binds a declared key at all — KotlinSpringControllerGenerator.kt:518-521 skips the PK column unconditionally (increment left to the column; uuid minted app-side at line 510). Scoped the sentence to TypeScript/C#/Java/Python and added a parenthetical naming the Kotlin exception. Applied inline this pass.🔧 Fix applied.
📝 1 wording or comment-placement note left for the author (no fix round spent):
docs/features/generated-mutations.md:74- The new "Create stores only what a client may set, in every port" paragraph stated "An assigned key (no @generation) is the caller's on create" as a cross-port rule, but Kotlin's generated create never binds a declared key at all — KotlinSpringControllerGenerator.kt:518-521 skips the PK column unconditionally (increment left to the column; uuid minted app-side at line 510). Scoped the sentence to TypeScript/C#/Java/Python and added a parenthetical naming the Kotlin exception. Applied inline this pass.scripts/integration-test.sh:176- Standalonescripts/integration-test.sh kotlin(andall) fails dependency resolution on a fresh checkout: run_kotlin installs onlymetadata,codegen-kotlin -am, but integration-tests-kotlin also needsmetaobjects-core-spring:8.2.2(and the kotlin module's own version line 8.2.2), which neither that install nor run_java'smetadata,om,omdb,codegen-spring -amprovides. First kotlin lane attempt in this run failed with 'Could not find artifact com.metaobjects:metaobjects-core-spring:jar:8.2.2'; aftermvn -DskipTests install -pl metadata,om,omdb,codegen-spring,core-spring -amthe lane passed. Pre-existing infrastructure gap, not introduced by this change (only pom version bumps touched those poms); ci-local's full run masks it because the reactor install populates .m2 first. Fix would be adding core-spring to run_kotlin's -pl list.server/csharp/MetaObjects.IntegrationTests/Api/ApiContractTphConformanceTest.cs:1- dotnet test truncates xUnit InlineData display names (scenarioPath cut at ~100 chars with an ellipsis), so the C# console/trx output cannot show WHICH scenario file each passing row is. Scenario identity for C# was therefore proven structurally: the loaders enumerate *.yaml (new scenario files auto-register), the lane class counts match the corpus sizes, and every C# lane ran with zero failures — but C# has no per-scenario-name pass line like Python/bun. No action needed; cosmetic observability gap.scripts/ci-local.sh --only ts-fast --only ts-unit --strict-toolchainsscripts/ci-local.sh --only ts-fast --only ts-unit --strict-toolchains (re-run at target: build + typecheck + TS conformance + per-package unit suites, includes the new zod-validators.test.ts case)METAOBJECTS_TEST_PG_URL=… scripts/integration-test.sh java (full Java persistence+api-contract integration suite; all api-contract classes 0 problems, generated core lane 32/32)surefire report mapping: TEST-…ApiContractGeneratedConformanceTest.xml testcase[20]=input-server-owned-dropped PASS; TphGeneratedApiContractConformanceTest [5]=tph-input-foreign-discriminator-dropped, [6]=tph-input-server-owned-dropped PASS; SecretFieldsGeneratedApiContractConformanceTest [1],[2] PASSMETAOBJECTS_TEST_PG_URL=… scripts/integration-test.sh kotlin (after installing core-spring dep; Kotlin generated lanes 32/32 core, TPH 13, secret-fields 2, all pass)mvn -pl codegen-spring,codegen-kotlin test (SpringServerOwnedInputCodegenTest 3 pass, KotlinServerOwnedCreateBindTest 1 pass, KotlinServerOwnedInputTest 2 pass)dotnet test MetaObjects.IntegrationTests (395 passed, 0 failed) + scoped verbose rerun of ApiContract{Generated,Tph,SecretFields,WriteThrough} + ServerOwnedCreateInputTests filter (60 passed)dotnet test MetaObjects.Codegen.Tests (1093 passed, incl. ServerOwnedCreateInputTests) + Conformance.Tests (2195) + Cli.Tests (345) + Render.Tests (364)cd server/python && uv run --extra dev --extra integration pytest tests/integration -q -n 4 (439 passed, 12 skipped) + verbose per-scenario runs of test_api_contract_generated/test_api_contract/test_api_contract_secret_fields/test_api_contract_tph_generatedMETAOBJECTS_TEST_PG_URL=… bun test --parallel=4 test/api-contract-{generated,write-through,tph,secret-fields}.test.ts test/api-contract.test.ts (93 passed) + serial 32/32 core generated lane + named -t runs for input-server-owned-dropped and tph-input-server-owned-droppedthrowaway emitted-artifact drive: generated Coupon (assigned string PK) + AuthorGen (increment PK) validators via runGen/entityFile, imported and executed — assigned key kept on InsertSchema, stripped from UpdateSchema, generated id stripped from update; FAILS at base commit (git checkout 783ac219e -- both zod-validators.ts copies)scripts/ci-local.sh --only gates --strict-toolchains (LOCAL CI PASSED: leak-scan, metamodel-version gate, publish-set parity, hygiene)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.