Repository navigation
Commit 00b08dc
authored
feat: page size, unknown-field 400s and validation issues in every port (#580)
* fix(python): pass only validated input to the repository in generated routes (#566)
* fix(python): generated routes hand the repository only the validated input (1.2.1)
The generated FastAPI create, PATCH and PUT handlers validated the body against
<Entity>Create / <Entity>Patch and then passed the RAW body to the repository.
Pydantic ignores undeclared keys and the input models leave out server-owned
fields, so a client-sent id, a readOnly field and a made-up field such as
isAdmin all reached the write. Security fix.
Each handler (plain and TPH per-subtype) now rebinds dto to the keys the input
model validated, at every depth, before any repository call, as the TypeScript
routes do. Undeclared and non-settable keys are dropped silently, never 400'd,
so a client sending an extra harmless field keeps working; values stay the
body's own, so repositories see the same value types as in 1.2.0.
Python package version 1.2.1 only; CHANGELOG entry under Security.
Regression gate: tests/integration/test_generated_router_validated_input.py.
* no-mistakes(document): python routes pass only validated input
* no-mistakes(lint): regenerate showcase site payload for PyPI 1.2.1
* fix(codegen): generated routes drop server-owned and undeclared input in every port
An audit after the Python 1.2.1 fix found the same request-input hole in the
other ports' generated create handlers. Each port now drops, silently and before
the write, a server-generated key, readOnly and derived fields, and on a TPH
per-subtype route the discriminator and sibling-subtype columns; undeclared keys
are dropped everywhere.
- Python: forward-port of the 1.2.1 fix; TPH create drops a body discriminator.
- Java: create nulls the dropped DTO components; DTOs ignore unknown properties.
- Kotlin: create writes only settable columns; entity classes ignore unknown keys.
- C#: create resets the generated key, discriminator and M:N navigations; every
readOnly property gets a private setter.
- TypeScript: an assigned primary key leaves the update schema.
Shared api-contract scenarios input-server-owned-dropped (core) and
tph-input-server-owned-dropped, a readOnly column in secret-fields, and an
`absent` assertion in every runner gate it.
* feat(codegen): a validation 400 lists every issue in every port
The same model answered a failed create or update differently by language:
TypeScript listed each problem, while C#, Java, Kotlin and Python returned a
bare {"error":"validation"}. Every port's generated routes and its hand-rolled
reference servers now answer 400 {"error":"validation","issues":[{code,path,
message}]} with every failure, codes in Zod's vocabulary and path as an array of
wire names.
- C#: ValidationIssues runtime file (ejected with routes); create reads the
body itself so an unbindable body lists its issue; PATCH collects instead of
returning on the first failure.
- Java: ValidationIssues runtime helper; a Patch binds every field before it
throws. Kotlin: per-package MetaValidationIssues.kt; create lists every
absent required value.
- Python: every Pydantic error mapped in constraint_errors; decimal failures
carry their wire path.
Shared scenarios validation-lists-issues and tph-validation-lists-issues, with a
new `issues` assertion in every runner, gate it in both lanes.
* feat(api): a page size for generated list routes, api.pagination (TypeScript)
List endpoints had no hard cap: a TypeScript or C# list with no `limit`
returned the whole table and `?limit=100000` was accepted everywhere. A project
can now set `"api": { "pagination": { "defaultLimit": N, "maxLimit": M } }` in
.metaobjects/config.json: a generated entity or projection list with no
`limit` answers the default page, and a `limit` above the cap answers
400 {"error":"limit_too_large","maxLimit":M}. Reports keep their own row cap
and opaque views their 1000.
- sdk reads and validates the block; the loaded root carries it
(apiPaginationOf), as it carries the wire format.
- runtime-ts mounts take a `pagination` option (pageLimit); the packaged and
reference Fastify and Hono routes emit it. Owned copies re-synced.
- meta init writes 50 / 1000 for a new project; `--force` over an existing
config does not add it. A project without the setting behaves as before, and
meta verify advises (rule unbounded-list-pages) when routes are wired.
- New api-contract `pagination/` sub-corpus, run in the TypeScript generated
lane. The C#, Java, Kotlin and Python routes do not read it yet: their REST
generators are under the non-TS freeze, pending that ruling.
A config key, not vocabulary: metamodelVersion does not move.
* feat(api): api.pagination in every port, and api.unknownFields (reject by default)
api.pagination (default page size and hard cap on generated list routes)
now reaches the C#, Java, Kotlin and Python generators as well as
TypeScript: no limit answers the default page, a limit over the cap is
400 limit_too_large. No setting keeps today's behaviour. verify advises
when routes are generated without it (TypeScript, Python, Java/Kotlin,
and C# under verify --codegen).
api.unknownFields (reject | drop, default reject): a generated create,
PUT or PATCH body carrying a key the entity does not declare answers
400 {"error":"unknown_fields","fields":[...]} in every port, before
validation, and writes nothing. drop keeps the old silent behaviour.
Declared server-owned keys (id, readOnly, @autoset, writeOnce on update,
the TPH discriminator, a sibling subtype's column) are still dropped, not
refused, so a client echoing back a row keeps working. Java and Kotlin
check the raw body, so the answer does not depend on the host's Jackson
mapper; a test proves it under both FAIL_ON_UNKNOWN_PROPERTIES values.
The pagination sub-corpus becomes api-settings/ and runs in every port's
generated lane; the core and tph corpora gain reject scenarios. meta init
writes both settings into a fresh config.
* chore(showcase): regenerate for api.unknownFields
* fix(api): code-point order for unknown_fields, every distinct validation issue, a negative limit refused under api.pagination
- unknown_fields lists keys in code-point order in every port (TypeScript and
C# sorted by UTF-16 code unit, which put a key outside the BMP first).
- A validation 400 keeps two distinct failures of one rule kind on one field
(Python and C# de-duplicated on path and code); a type error still lists once.
- Under api.pagination a negative limit answers 400 pagination.invalid_value in
every port instead of reaching the store (SQLite reads LIMIT -1 as no limit).
New api-settings/limit-negative scenario.
- Python validated-input tests follow api.unknownFields; advanced-modeling
example regenerated; C# routes generator header names the current contract.
* fix: generated create routes drop server-owned input across ports (1.2.x security) (#568)
* fix: generated create routes store only client-settable fields (1.2.x security)
Python 1.2.1 stopped its generated routes from handing raw request input to
the repository. The same audit found related create-path holes in 1.2.0 in
the other four ports; this closes each in its own idiom. Server-owned values
are dropped silently, never answered with 400.
- Java (codegen-spring): create strips a generated id, readOnly and derived
fields; a TPH per-subtype create also strips the body discriminator and
sibling-subtype fields.
- Kotlin (codegen-kotlin): create skips readOnly/derived columns; a TPH
per-subtype create writes only the route subtype's own columns.
- C# (MetaObjects.Codegen): every readOnly property shape gets a private
setter; create resets a generated id, the TPH discriminator and M:N
navigations before Add.
- TypeScript (codegen-ts): the update schema omits primary-key fields, so
PUT/PATCH can no longer re-key a row with an assigned key.
Proof: new shared api-contract scenarios (core + TPH input-server-owned,
TPH foreign discriminator) and a readOnly `role` field in secret-fields, run
in every port's generated lane and the reference lanes; a new `unset`
assertion key in all five harnesses. In-memory test repositories now store
what they are handed, so the scenarios fail on the 1.2.0 generators.
Proposed versions (not published): npm 1.2.2, NuGet 1.2.2, Maven 8.2.2;
PyPI unchanged at 1.2.1. metamodelVersion unchanged.
* fix: keep a @required readOnly field creatable in C# and Java generated create
Pre-gate review follow-ups to the 1.2.x create-input patch:
- C#: the required-key check skips readOnly fields (the private setter
never binds them), and create validation ignores a violation naming
only a @required readOnly member, as Java's SERVER_OWNED_ON_CREATE does.
- Java: the create-validation server-owned set covers every DTO component,
so a nulled readOnly or derived value-object column no longer 400s.
- TypeScript: drop the now-dead PK guard in the update-schema nullable arm
and list the PK rule in updateSchemaFields' doc comment.
* no-mistakes(review): apply reviewer inline fixes
* no-mistakes(review): Kotlin readOnly create fix + C# reset skip
* no-mistakes(document): docs: finish stale corpus counts from input fix
* fix(cli): prune emptied skill directories after a --skills-dir move; install every module the Kotlin integration lane needs
meta init --refresh-docs --skills-dir <new> removed the untouched skill files at
the old path but left their directories behind, which read as the old copy still
being there. Walk up from each pruned file and remove the directories it left
empty, stopping at the first that still holds anything and never removing the
skills directory itself.
scripts/integration-test.sh kotlin installed only metadata and codegen-kotlin, so
on an .m2 without the other metaobjects artifacts integration-tests-kotlin failed
to resolve core-spring and om, and codegen-kotlin-exposed1x-check metadata-ktx.
* test(render): hold the email helper in the runtime-drift corpus case
Every generated render path in the five ports already raises
ERR_VAR_NOT_ON_PAYLOAD for a template variable not on the payload
(1.3.0, #520), and runtime-drift/ held the document and prompt helpers.
The @kind: email helper was not in the case. Add WelcomeEmail plus
email-subject/, email-html/ and email-text/ drift directories, one
drifted part each, and check every part raises in the TS, Python, C#,
Java and Kotlin runners.
* feat(init): dotnet meta init and metaobjects init write the api block TypeScript meta init writes
A new project gets api.pagination 50/1000 and api.unknownFields reject in
.metaobjects/config.json from every port's init; an existing config is never edited.
* feat(init): dotnet meta init and metaobjects init also write migrate.foreignKeyIndexes and verify.handEdits
The same new-project keys TypeScript meta init writes since #577.
* feat(api): drop undeclared value-object members everywhere and share the api config cases
- New jsonb scenario jsonb-nested-undeclared-key-dropped: api.unknownFields judges the top
level only, so a member a value object does not declare is dropped on create and PATCH and
never stored, while the open jsonb bag keeps every key. The reference servers in every port
drop such members; the Java generated value-object record now carries
@JsonIgnoreProperties(ignoreUnknown = true) (it answered 400 invalid_type).
- New shared config corpus api-settings/config-blocks.json (valid and refused api blocks), run
by the TypeScript, C#, Java and Python config readers. A page size is a positive whole number
however JSON spells it, at most 2147483647: C# now reads 50.0, TypeScript and Python refuse
anything above the int32 range.
- CHANGELOG: an Upgrading section (api.unknownFields reject as the one deliberate default change,
the C# readOnly private setter), init parity across ports, the nested-member rule. Counts,
READMEs, api-contract.md and the migration guide updated; showcase Java regenerated.
* fix(api): close the code-review findings on the input and page-size work
- C#: with api.pagination set, `limit=0` served the default page; it is now a page of zero rows,
as in every other port. New shared scenario api-settings/limit-zero (all five ports green).
- C#: the unknown-field check matches a key the way the route binds the body (the app's
System.Text.Json options; the ASP.NET web default ignores case), so `Title` is the declared
`title`, not a 400. The verify advisory matches the routes generator by type or exact name,
not by a "routes" substring.
- Python: a rejected decimal's text is no longer echoed into the 400 issue message; the
unbounded-list-pages advisory fires only when the routes generator is wired; the dead
_DECIMAL_COERCE constant is gone.
- Java: UnreadableBody's Javadoc describes the issues envelope it returns.
- Docs: M:N traversal routes take no limit and are not paged by api.pagination (stated as the
boundary); the C# port doc no longer says dotnet meta init writes no config. Counts updated.
* refactor: read the project config once in the Maven mojo; drop a no-op path coercion in Python issues
Simplify pass: AbstractMetaDataMojo maps its four project settings from one read of
.metaobjects/config.json, and pydantic_issues copies loc as-is (its entries are already int or str).
* no-mistakes(review): Scope ignoreUnknown to request bodies; fix review items
* no-mistakes(review): Drop discriminator on Python TPH update; fix scenario text
* no-mistakes(review): apply reviewer inline fixes
* no-mistakes(review): Fix doc counts, dead guard, stale comments, vacuous assertion
* no-mistakes(review): apply reviewer inline fixes
* no-mistakes(review): Fix stale routes comment in C# api-settings factory
* no-mistakes(review): Fix stale eject docs, vacuous C# check, assertion messages
* no-mistakes(review): Refuse non-numeric C# page bounds with 400
* no-mistakes(review): Refuse out-of-range or negative C# offset
* no-mistakes(review): Drop source-grepping Python router tests
* no-mistakes(review): apply reviewer inline fixes
* test(ts): re-sync the owned zod-validators copy after the pkFields reference change
The input-handling change edited the codegen-ts reference source but not the
owned copy under test-generators, so cli/test/owned-copies-current.test.ts
(the 'owned copies are what meta eject writes' gate) failed: the copy on
disk kept the pre-change update-shape text. bun scripts/sync-owned-template-copies.ts
re-synced 1 of 128 owned copies; no other copy drifted.
* no-mistakes(test): Validate re-synced zod-validators owned copy
* no-mistakes(test): apply changes made during test validation
* no-mistakes(document): Correct init config docs for C# and Python
* test(kotlin): expect table-qualified columns in the TPH create autoSet tests
The TPH per-subtype create now writes every column through the table object
(it[AuthTable.autoCreatedAt]), so a column named body, issues or unknownKeys
cannot be shadowed by the handler's locals. Two KotlinAutoSetStampingTest
cases still asserted the unqualified form and failed the java-slow lane.1 parent dbd7e42 commit 00b08dc
350 files changed
Lines changed: 12100 additions & 1192 deletions
File tree
- agent-context/templates
- docs
- features
- migrations
- ports
- examples
- advanced-modeling
- .metaobjects/.gen-state
- codegen
- generators
- runtime
- drizzle-fastify
- templates
- src/generated
- showcase
- .metaobjects/.gen-state
- codegen
- generators
- runtime
- drizzle-fastify
- templates
- generated
- csharp
- java/acme
- kotlin/acme
- python
- ts
- fixtures
- agent-context-conformance
- csharp/expected/.metaobjects
- java-kotlin-react-tanstack/expected/.metaobjects
- java-react/expected/.metaobjects
- python/expected/.metaobjects
- ts-react-tanstack/expected/.metaobjects
- api-contract-conformance
- api-settings
- .metaobjects
- scenarios
- jsonb
- scenarios
- scenarios
- secret-fields
- scenarios
- tph
- scenarios
- conformance/routes-file-hono-basic/expected
- contract-conformance
- m2m/expected
- schemas/acme/social
- secret-fields/expected
- schemas/acme/secrets
- template-output-render-conformance
- runtime-drift
- email-html/emails
- email-subject/emails
- email-text/emails
- scripts
- server
- csharp
- MetaObjects.Cli.Tests
- MetaObjects.Cli
- MetaObjects.Codegen.Tests
- MetaObjects.Codegen
- Generators
- Runtime
- MetaObjects.IntegrationTests/Api
- MetaObjects
- Config
- Loader
- Meta
- java
- codegen-base/src/main/java/com/metaobjects/generator/util
- codegen-kotlin
- src
- main/kotlin/com/metaobjects/generator/kotlin
- test
- kotlin/com/metaobjects/generator/kotlin
- resources/snapshots
- entity-with-bidirectional-fk/acme/blog
- entity-with-controller/acme/blog
- entity-with-decimal-float-filter-wire-string/acme/catalog
- entity-with-decimal-float-filter/acme/catalog
- entity-with-enum/acme/game
- entity-with-fk/acme/blog
- entity-with-storage-wire-omit/acme/commerce
- entity-with-storage/acme/commerce
- entity-with-tph/acme/auth
- entity-with-view/acme/report
- single-entity-primitives/acme/demo
- codegen-spring
- src
- main/java/com/metaobjects/generator
- spring
- runtime
- test
- java/com/metaobjects/generator/spring
- runtime
- resources/golden/inline-enum-names/expected/acme/shipping
- integration-tests-kotlin/src/test/kotlin/com/metaobjects/integration/kotlin/api
- apisettings
- generated
- generated
- jsonb
- secretfields/generated
- tph/generated
- integration-tests/src/test/java/com/metaobjects/integration/api
- generated
- tph/generated
- maven-plugin/src
- main/java/com/metaobjects/mojo
- test/java/com/metaobjects/mojo
- metadata/src
- main/java/com/metaobjects
- config
- loader
- test/java/com/metaobjects/config
- python
- src/metaobjects
- codegen
- generators
- runtime
- config
- meta
- tests
- codegen
- config
- conformance
- integration
- runtime
- typescript/packages
- cli
- src
- commands
- lib
- test
- unit
- codegen-ts
- src
- reference
- templates
- test
- __snapshots__
- contract
- golden/__snapshots__
- package
- shop
- commerce
- users
- postgres
- sqlite
- templates
- integration-tests
- src
- test
- metadata/src
- runtime-ts
- src
- drizzle-fastify
- hono
- test
- sdk
- src
- test
- test-generators/src
- generators
- templates
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
52 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
53 | 55 | | |
54 | 56 | | |
55 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
445 | | - | |
| 445 | + | |
446 | 446 | | |
447 | | - | |
| 447 | + | |
448 | 448 | | |
449 | 449 | | |
450 | 450 | | |
| |||
454 | 454 | | |
455 | 455 | | |
456 | 456 | | |
457 | | - | |
458 | | - | |
459 | | - | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
460 | 463 | | |
461 | | - | |
| 464 | + | |
462 | 465 | | |
463 | 466 | | |
464 | 467 | | |
465 | 468 | | |
466 | 469 | | |
467 | 470 | | |
468 | | - | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
469 | 475 | | |
470 | 476 | | |
471 | 477 | | |
| |||
725 | 731 | | |
726 | 732 | | |
727 | 733 | | |
728 | | - | |
| 734 | + | |
729 | 735 | | |
730 | 736 | | |
731 | 737 | | |
| |||
0 commit comments