Repository navigation
e2e: Playwright browser tests against the fixture instance - #7
Conversation
The pipeline's repo contract puts browser tests in e2e/ (Playwright, against E2E_BASE_URL). vimmary had none: the 2026-08-07 decision (archive/DECISIONS.md) limited web/ to vitest over pure helpers and left a browser to a separate decision. This is that decision. A PR that changes UI behaviour can now prove it with a checked-in test, which REVIEW.md rule 1 asks for. - e2e/ is its own npm package with @playwright/test pinned, so web/'s dependencies stay as they are. - scripts/e2e runs the tests after the HTTP checks: against the new image in the upgrade test, and against E2E_BASE_URL in a session. - Browsers go to Playwright's default cache: a cloud session presets PLAYWRIGHT_BROWSERS_PATH to a build of another Playwright version and PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD. scripts/setup installs them (a failure is logged, not fatal), scripts/e2e ensures them. - CI keeps traces and screenshots of a failed run as an artifact. - The tests cover the library, a video's summary, keyword search, the inbox, channels, stats and settings pages, and the absent sign-out button without application login. An uncaught page exception fails any test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: approveCommit The PR adds browser tests, run by scripts/e2e, that check the fixture library, opening a video, search, the Inbox, Channels, Stats and Settings pages, and that the nav has no sign-out button without login. The app itself is unchanged. The tests fail on any uncaught page exception, failed runs leave traces and screenshots, and CI uploads them as an artifact. scripts/setup now also installs the Playwright dependencies and Chromium, and a failed install is only logged. I found no blockers: no migration, no startup, version or health-check change, no secrets, and no check was weakened (the CI and script changes only add steps). The shown test output matches the named tests. Two gaps are minor and not blockers. The setup tolerance for a failed browser install, and the cloud-session environment handling, were not run, as the PR says. The artifact upload step is also unexercised by a green run. Nothing is needed outside this repo. |
|
preview: |
|
live: |
Adds Playwright browser tests in
e2e/, as the pipeline's repo contract prescribes. UI changes can now be proven with a checked-in test (REVIEW.mdrule 1); until nowweb/had only vitest over pure helpers (decision of 2026-08-07 inarchive/DECISIONS.md, which left a browser to a separate decision — this PR is that decision). The app is unchanged.Acceptance criteria
scripts/e2eruns the Playwright tests ine2e/after the HTTP checks: against the new image in the upgrade test, and againstE2E_BASE_URLwhen that is set.e2e/test-results/; CI uploads them as an artifact.scripts/setupinstalls e2e/'s dependencies and Chromium; a failed browser install is logged and does not fail the setup. Browsers go to Playwright's default cache, independent of a presetPLAYWRIGHT_BROWSERS_PATH/PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD(cloud session).Test per criterion
scripts/e2elocally (output below); the CIe2ejob of this PR.e2e/tests/library.spec.ts(8 tests),e2e/tests/fixtures.ts(pageErrors, auto fixture).ci.ymlruns only on failure, so this PR's green run does not exercise it.scripts/setuplocally (exit 0);playwright()inscripts/lib/common.shunsets both variables. Not run in a cloud session yet.Test output
Notes
base_url(Origin check); follow-up.e2e/package*.jsongets the normal review:scripts/renovate-only.shis unchanged.Production changes
None
🤖 Generated with Claude Code