Repository navigation
e2e: native mode for sessions that cannot build the image - #8
Conversation
A cloud session cannot run scripts/e2e: docker build fails on the egress proxy's certificate, and E2E_BASE_URL needs an instance the session would have to assemble itself. E2E_NATIVE=1 builds the frontend and the binary, starts them against Postgres from compose.test.yaml with the fixtures, and runs the HTTP checks and the Playwright tests. The upgrade test needs images and stays with CI. The instance listens on a free loopback port with the health listener off, so it does not collide with a running vimmary or other apps on 8080/8081. CLAUDE.md and the verify skill now ask for scripts/e2e on a change under web/ as well, since the browser tests cover the frontend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: request changesCommit This PR adds an Blockers
|
|
preview: |
The review of #8 asked for a test of acceptance criterion 3: on a failed run the app's log is printed and the database container removed. scripts/e2e-native_test.sh, run by scripts/lint, starts the native mode with a config the app cannot parse (E2E_CONFIG, new) and checks the exit code, the early-exit message, the app's startup-failure log line, and that no vimmary-e2e-native container remains. Without Docker it is skipped, except in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review: approveCommit This PR adds an |
|
preview: |
|
live: |
Lets a cloud session run the end-to-end checks, including the Playwright tests from #7, before it pushes. Until now it could not:
docker buildfails there on the egress proxy's certificate, so the image path ofscripts/e2eis unavailable. The app is unchanged.Acceptance criteria
E2E_NATIVE=1 scripts/e2ebuilds the frontend and the binary (with the build SHA), starts them against Postgres fromcompose.test.yamlwith the fixtures, and runs the HTTP checks and the Playwright tests, withoutdocker build.E2E_NATIVEthe image path and the upgrade test are unchanged.CLAUDE.mdand the verify skill ask forscripts/e2eon a change underweb/, and name the native mode for a session wheredocker buildfails.Test per criterion
1, 2.
E2E_NATIVE=1 scripts/e2elocally (output below; port 64951 was chosen by the script).3. Success: same run,
docker ps -alists novimmary-e2e-native-*container afterwards. Failure:scripts/e2e-native_test.sh(run byscripts/lint) starts the native mode with a config the app cannot parse (E2E_CONFIG) and checks the exit code, the early-exit message, the app'sstartup failedlog line and that no container remains. Counter-check: with thetailof the log removed fromscripts/e2e, the log check fails (below).4. The CI
e2ejob of this PR runs the image path.5. Documentation only.
Test output
scripts/e2e-native_test.shneeds Docker; without it the test is skipped, except withCI=true.Not yet run in a cloud session.
Production changes
None
🤖 Generated with Claude Code