docs(superpowers): post-implementation notes for release-pipeline#177
Merged
Conversation
Captures the six real bugs that surfaced during code review (#168 fixes) and post-merge validation (PRs #171, #172, #173, #175), plus lessons for the next adapter — chiefly that github.event_name and github.ref lie inside reusable workflows, and that dry-run requires deliberate plumbing at every step touching external state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a post-mortem section to
docs/superpowers/specs/2026-05-21-release-pipeline-design.mdcapturing the six real bugs that surfaced while landing the new release pipeline:cz bump --dry-rundoesn't update files, plus sccache/environment/pin polish).github.event_namemisuse → orphan v0.25.0 release, ci(release-pipeline): don't pin publish to nonexistent tag in fresh-bump dry-run #173 publish can't pin nonexistent tag, ci(release): check out the tag in real mode #175 release.yaml neededref: inputs.tag).Headline lesson: in a reusable workflow,
github.event_namereports the parent event andgithub.refis the dispatcher's ref. Don't gate on either; useinputs.*directly. Dry-run also needs deliberate plumbing at every step that touches external state.Plan file gets a one-line pointer back to the spec for these notes.