Surface marker scan health and dangling claims in CI comments - #178
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Mark Beacom <m@beacom.dev>
mbeacom
force-pushed
the
mbeacom-marker-comment-reporting
branch
from
August 26, 2026 21:45
f63902f to
1a827e0
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Marker sections need Markdown boundaries, and the budget-priority regression test currently filters out all marker claims.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Surfaces marker scan failures and unresolved claims in CI comments while preserving advisory semantics and validation priority.
Changes:
- Adds bounded marker health and unresolved-claim sections.
- Adds regression tests for rendering and non-blocking behavior.
- Documents marker reporting and checkout-root requirements.
File summaries
| File | Description |
|---|---|
packages/ci/src/comment.ts |
Renders marker health and claim findings. |
packages/ci/test/comment-render.test.ts |
Tests bounded marker comment rendering. |
packages/ci/test/action.test.ts |
Verifies dangling markers remain non-failing. |
README.md |
Summarizes marker reporting behavior. |
site/src/content/docs/ci.mdx |
Documents marker sections and checkout caveat. |
Review details
- Files reviewed: 5/7 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+125
to
+128
| lines.push( | ||
| '', | ||
| 'These files could not be inspected for `@adr` markers; an empty result does not prove that no marker is present.', | ||
| ); |
Comment on lines
+152
to
+156
| const remaining = claims.length - shown.length; | ||
| if (remaining > 0) { | ||
| lines.push(`- …and ${remaining} more marker claim${remaining === 1 ? '' : 's'}`); | ||
| } | ||
| return lines; |
Comment on lines
+157
to
+161
| outcome.findings.push(...Array.from({ length: 4000 }, (_, index) => ({ | ||
| rule: 'dangling-marker', | ||
| severity: 'warn' as const, | ||
| message: `claim ${index} ${'x'.repeat(60)}`, | ||
| path: 'src/a.ts', |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Mark Beacom <m@beacom.dev>
Decisions governing this change
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Mark Beacom <m@beacom.dev>
mbeacom
added
the
gate-change-acknowledged
This was referenced Aug 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #126
Closes #112