fix(ci): surface marker scan health and dangling claims - #176
Closed
mbeacom wants to merge 2 commits into
Closed
Conversation
Distinguish incomplete marker scans from unresolved marker claims, cap and escape PR-authored details, and preserve changed-record validation priority. Document the checkout-root requirement and add observed-failing regressions for both silent states.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Mark Beacom <m@beacom.dev>
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is complete and well tested, with only a minor wording correction identified.
Pull request overview
Surfaces marker scan failures and unresolved inbound claims in advisory CI comments.
Changes:
- Adds bounded, escaped marker-health sections without affecting verdicts.
- Expands CI tests for scan states, safety, and comment budgets.
- Documents checkout requirements.
File summaries
| File | Description |
|---|---|
packages/ci/src/comment.ts |
Renders marker advisories. |
packages/ci/dist/index.js |
Updates the committed Action bundle. |
packages/ci/test/comment-render.test.ts |
Tests rendering and safety. |
packages/ci/test/action.test.ts |
Tests end-to-end behavior. |
README.md |
Documents marker reporting and checkout. |
site/src/content/docs/ci.mdx |
Expands CI guidance. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Decisions governing this change
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Mark Beacom <m@beacom.dev>
Owner
Author
|
Superseded by #178, which carries the reviewed marker-reporting implementation, canonical Linux Bun 1.3.14 Action bundle, Markdown boundary fix, and complete CI evidence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_WORKSPACEBoth marker sections remain advisory and do not affect
CheckOutcome.okor the Action verdict. A deliberately truncated 8192-byte header read remains a successful scan and does not trigger the incomplete-scan notice.Validation
bun testbun run typecheckbun test packages/ci/testcd site && bun run buildCloses #126
Closes #112