Skip to content

fix(ci): surface marker scan health and dangling claims - #176

Closed
mbeacom wants to merge 2 commits into
mainfrom
mbeacom-fix-marker-pr-reporting
Closed

fix(ci): surface marker scan health and dangling claims#176
mbeacom wants to merge 2 commits into
mainfrom
mbeacom-fix-marker-pr-reporting

Conversation

@mbeacom

@mbeacom mbeacom commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • render Inbound marker scan incomplete when changed files are absent, unreadable, outside the worktree, or skipped by the scan cap
  • render Unresolved inbound markers when a completed scan finds dangling or cross-log marker claims
  • cap unresolved examples at 10, safely escape PR-authored paths/messages, and keep changed-record validation errors first under the global comment budget
  • document that the PR head checkout must remain at GITHUB_WORKSPACE

Both marker sections remain advisory and do not affect CheckOutcome.ok or the Action verdict. A deliberately truncated 8192-byte header read remains a successful scan and does not trigger the incomplete-scan notice.

Validation

  • bun test
  • bun run typecheck
  • bun test packages/ci/test
  • cd site && bun run build

Closes #126
Closes #112

Distinguish incomplete marker scans from unresolved marker claims, cap and escape PR-authored details, and preserve changed-record validation priority. Document the checkout-root requirement and add observed-failing regressions for both silent states.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Signed-off-by: Mark Beacom <m@beacom.dev>
Copilot AI balanced review requested due to automatic review settings August 26, 2026 21:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation is complete and well tested, with only a minor wording correction identified.

Pull request overview

Surfaces marker scan failures and unresolved inbound claims in advisory CI comments.

Changes:

  • Adds bounded, escaped marker-health sections without affecting verdicts.
  • Expands CI tests for scan states, safety, and comment budgets.
  • Documents checkout requirements.
File summaries
File Description
packages/ci/src/comment.ts Renders marker advisories.
packages/ci/dist/index.js Updates the committed Action bundle.
packages/ci/test/comment-render.test.ts Tests rendering and safety.
packages/ci/test/action.test.ts Tests end-to-end behavior.
README.md Documents marker reporting and checkout.
site/src/content/docs/ci.mdx Expands CI guidance.
Review details
  • Files reviewed: 5/6 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread site/src/content/docs/ci.mdx
@github-actions

Copy link
Copy Markdown

Decisions governing this change

  • 0011 — Host the canonical JSON Schema at its $id on adrkit.dev
    • via path: site/**
  • 0016 — Require every check to be observed failing before it counts as coverage
    • via path: packages/*/test/**
  • 0022 — Scan inbound markers in check and CI without giving them exit-code authority
    • via path: packages/ci/src/**
  • 0026 — Identify the CI comment by the strongest author evidence the token allows
    • via path: packages/ci/src/comment.ts
    • via path: site/src/content/docs/ci.mdx
  • 0030 — Keep extension surfaces that carry a dependency tree outside this repository
    • via path: packages/ci/**
  • 0032 — Publish one lockstep OCI image after the coordinated release succeeds
    • via path: README.md
  • 0033 — Select interactive graph presentation at the CLI boundary while preserving piped DOT
    • via path: site/src/content/docs/**

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Mark Beacom <m@beacom.dev>
@mbeacom

mbeacom commented Aug 27, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #178, which carries the reviewed marker-reporting implementation, canonical Linux Bun 1.3.14 Action bundle, Markdown boundary fix, and complete CI evidence.

@mbeacom mbeacom closed this Aug 27, 2026
@mbeacom
mbeacom deleted the mbeacom-fix-marker-pr-reporting branch August 27, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants