Resolve Job inputs automatically in decorated flows - #885
Open
Andrew-S-Rosen wants to merge 17 commits into
Open
Resolve Job inputs automatically in decorated flows#885Andrew-S-Rosen wants to merge 17 commits into
Andrew-S-Rosen wants to merge 17 commits into
Conversation
Andrew-S-Rosen
marked this pull request as ready for review
August 10, 2026 21:07
2 tasks
This reverts commit 6f20c0c.
Andrew-S-Rosen
force-pushed
the
agent/resolve-job-inputs-in-decorated-flows
branch
from
August 11, 2026 17:04
5cd6cf4 to
e4b1f76
Compare
Member
Author
|
@utf --- could I get your review when you have a moment? Thanks. |
gpetretto
reviewed
Aug 20, 2026
gpetretto
left a comment
Contributor
There was a problem hiding this comment.
Hi @Andrew-S-Rosen,
I think this would be interesting. I have left a few cosmetic comments and one with a major concern.
In general, I don't expect this to conflict with #870
Member
Author
|
@gpetretto Thank you very much for the helpful review! I think I have addressed your comments. The buggy code you pointed out has since been removed entirely. There was an edge case I was trying to resolve (mentioned in #885 (comment)), but it is different than #884 and probably not sensible anyway. I have streamlined this PR to focus on the main issue at hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #884.
What changed
JobandFlowvalues passed to jobs inside@flow-decorated functions into their output references automatically.Why
The decorated-flow build context already collects delayed jobs, but downstream job construction retained whole
Jobobjects as inputs. This produced an invalid job argument and required users to write.outputexplicitly. Replacing these values while the decorated flow is being built makes the shorthand behave as expected without changing job construction outside@flow.