Normalize flow outputs and retain dynamic subflow jobs - #888
Closed
Andrew-S-Rosen wants to merge 1 commit into
Closed
Normalize flow outputs and retain dynamic subflow jobs#888Andrew-S-Rosen wants to merge 1 commit into
Andrew-S-Rosen wants to merge 1 commit into
Conversation
Member
Author
|
Superseded by #885. The relevant changes and regression tests have been consolidated there using a single shared normalization helper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JobandFlowvalues returned by@flowinto output references.Why
Downstream workflow adapters currently need to wrap decorated flow outputs recursively and compose
@jobwith@flowto prevent intermediate jobs in dynamic subflows from being lost. This behavior is general Jobflow composition logic and belongs upstream.Together with #885, this allows Quantum-Accelerators/quacc#3405 to remove its Jobflow-specific normalization and subflow patches from
src/quacc/wflow_tools/decorators.py.Additional dependencies introduced
None.
Validation
PYTHONPATH=src python -m pytest tests/core/test_flow_decorator.py tests/core/test_job.py -q— 39 passed, 1 xfailedpython -m ruff check --ignore PLR0917 src/jobflow/core/flow.py src/jobflow/core/job.py tests/core/test_flow_decorator.py tests/core/test_job.py— passedgit diff --check— passedChecklist