Skip to content

deps.lock: pin the bundled node for the packs' Lore selectors #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m4ttheweric merged 1 commit into from
Nov 3, 2026
Merged

deps.lock: pin the bundled node for the packs' Lore selectors #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/__tests__/deps-lock-file.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ describe("rt-tray/deps.lock", () => {
expect(by["age"]?.version).toBe(by["age-keygen"]!.version);
expect(by["age"]?.extract).toBe("age/age");
});
// Team packs' Lore rule selectors run their vendored bundle on this node via
// `rt deps resolve node`; dropping it breaks those reviews.
test("node stays a bundled helper under Contents/Helpers", () => {
const node = lock.tools.find((t) => t.name === "node");
expect(node?.kind).toBe("helper");
expect(node?.status).toBe("bundled");
expect(node?.bundlePath?.startsWith("Contents/Helpers/")).toBe(true);
});
// Upstream publishes no darwin binary and the Homebrew bottle links brew-only
// dylibs, so zstd is compiled from its sha-pinned release tarball.
test("zstd builds from the upstream source tarball", () => {
Expand Down
Loading