[m4ttheweric]

Adds a guard test that deps.lock keeps node as a bundled helper. Team packs' Lore rule selectors run their vendored bundle on it through rt deps resolve node, so a helper trim that drops it would break those reviews silently.

What changed

• lib/__tests__/deps-lock-file.test.ts: asserts node is kind helper, status bundled, with a bundlePath under Contents/Helpers/

Verification

bun test lib/__tests__/deps-lock-file.test.ts passes (11 tests), including node stays a bundled helper under Contents/Helpers.

Trivial test-only change; proposing to skip the CodeRabbit review.
engine-floor: unchanged test only

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Expanded automated checks to verify that the bundled runtime is packaged in the expected application location. This helps detect packaging issues earlier and supports more reliable app builds. No end-user functionality or behavior changed in this update.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds a test for the node lockfile entry. It checks that the entry is a bundled helper and that its bundle path begins with Contents/Helpers/.

Changes: Node lockfile contract

Layer / File(s)	Summary
Assert node metadata lib/__tests__/deps-lock-file.test.ts	The test checks that node has kind helper, status bundled, and a bundle path beginning with Contents/Helpers/.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

• m4ttstack/mattstack#963: Updates bundle-aware lookups that read helper metadata from deps.lock, including bundlePath.
• m4ttstack/mattstack#927: Updates the deps.lock tool set, including the node pin.

Merge Risk: Minimal · up to e3790

No actionable merge-blocking risk was identified.

Architecture risk: Low · up to e3790

The change affects 1 system.

Changed systems: lib

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — lib (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in lib/tests/deps-lock-file.test.ts: Added a test asserting that node has kind helper, status bundled, and a bundle path beginning with Contents/Helpers/.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Title check		The title names the change: it pins the bundled node helper for the packs' Lore selectors. The raw summary describes a test that requires the node lockfile entry to stay a bundled helper under Content…	Rename the title to describe the test-only change, for example: 'test: guard that node stays a bundled helper in deps.lock'. Alternatively, if deps.lock must change, confirm the diff includes that edit. The current diff summary lists only t…

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Full details: Title check

Explanation

The title names the change: it pins the bundled node helper for the packs' Lore selectors. The raw summary describes a test that requires the node lockfile entry to stay a bundled helper under Contents/Helpers/. The title says 'pin' and 'deps.lock', but the changeset adds a guard test in lib/tests/deps-lock-file.test.ts and does not modify deps.lock. The title therefore overstates the change, and the objectives state it is a test-only change. The title is partially related: it refers to the real subject (the bundled node entry and the Lore selectors) but describes it as a lockfile change.

Resolution

Rename the title to describe the test-only change, for example: 'test: guard that node stays a bundled helper in deps.lock'. Alternatively, if deps.lock must change, confirm the diff includes that edit. The current diff summary lists only the test file.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ast-grep (0.51.1)

ast-grep could not parse rule config: /ast-grep-rules/ast-grep-essentials/rules/cpp/security/weak-cipher-cryptopp-cpp.yml

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

lib/__tests__/deps-lock-file.test.ts

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 10.13.0

Error: typescript-eslint does not support TS 7.0.
at Object. (/.eslint-tmp/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1929:14)
at Object..js (node:internal/modules/cjs/loader:2060:10)
at Module.load (node:internal/modules/cjs/loader:1651:32)
at Module._load (node:internal/modules/cjs/loader:1443:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:372:15)
at ModuleWrap. (node:internal/modules/esm/translators:244:9)
at ModuleJob.run (node:internal/modules/esm/module_job:561:25)
at async node:internal/modules/esm/loader:647:26

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 466a4292-e489-458a-b9e2-6f6a7052b231

Commits

Reviewing files that changed from the base of the PR and between 77ab207 and e3790a4.

Files selected for processing: 1

• lib/__tests__/deps-lock-file.test.ts

Included review availability: This review used your included allowance. 5 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.