Skip to content

settings: register review.ruleSelector #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m4ttheweric merged 2 commits into from
Oct 29, 2026
Merged

settings: register review.ruleSelector #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea5d402
settings: register review.ruleSelector
m4ttheweric Oct 29, 2026
b035dee
settings: review.ruleSelector review fixes
m4ttheweric Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions apps/console/src/app/settings/groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ export const GROUPS: Group[] = [
blurb: 'How rt lays out the MR and PR descriptions it writes.',
match: prefix('rt.evidence.'),
},
{
id: 'review',
label: 'Reviews',
tier: 'rt',
blurb: 'How the team pack runs its reviews.',
match: prefix('review.'),
},
{
id: 'notifications',
label: 'Notifications & gates',
Expand Down
1 change: 1 addition & 0 deletions packages/rt-client/src/settings/__tests__/registry-console-ready.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ const NO_SCHEMA_YET: readonly string[] = [
"rt.gates.escalationTtlMinutes",
"rt.logLevel",
"rt.logRetentionDays",
"review.ruleSelector",
"rt.runsPruneDays",
"rt.ui.background",
"rt.worktreeMergeCleanupNotice",
Expand Down
3 changes: 2 additions & 1 deletion packages/rt-client/src/settings/__tests__/registry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,9 @@ describe("settings/registry", () => {
"telemetry.enabled",
"rt.evidence.foldScreenshots",
"rt.notify.sounds",
"review.ruleSelector",
];
expect(suiteKeys).toHaveLength(101);
expect(suiteKeys).toHaveLength(102);

expect(allDefs().map((d) => d.key).sort()).toEqual(
[...migratedFalseKeys, ...migratedTrueKeys, ...suiteKeys].sort(),
Expand Down
8 changes: 8 additions & 0 deletions packages/rt-client/src/settings/registry-defs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,14 @@ const ROWS: readonly SettingDef[] = [
repoScoped: true,
description: "Fold each case's screenshots in the evidence section rt writes into an MR or PR description, behind a summary that names the case, so reviewers scroll past them to the approvals and pipeline.",
},
{
key: "review.ruleSelector",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
type: "boolean",
scopes: ["team", "user", "machine"],
default: false,
merge: "replace",
description: "Turns on the team pack's review rule selector. The pack's rule-selector fill reads it on every review.",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
},
{
key: "rt.logLevel",
type: "string",
Expand Down
Loading