fix: Update the path of the index.html - #124
Merged
Merged
Conversation
Contributor
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
Mar 4, 2026
thespad
pushed a commit
that referenced
this pull request
Jun 6, 2026
The Angular build output moved into a browser/ subfolder, so the index.html that Ombi rewrites for BASE_URL lives at dist/browser/index.html. Commit 32375bf reintroduced the pre-#124 path (dist/index.html) while adding the LSIO_READ_ONLY_FS guard, so the real file is never chowned to abc and Ombi cannot apply BASE_URL (blank page behind a subpath reverse proxy). Restore the browser/ path inside the read-only guard. Closes #126
thespad
added a commit
that referenced
this pull request
Jun 6, 2026
fix: chown the correct index.html path (dist/browser) — regression of #124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We have changed the location of the index.html, it's now in another sub folder due to switching the frontend build system
Benefits of this PR and context:
Makes Ombi work with sub-dir setups again
How Has This Been Tested?
Verified locally
Source / References:
Outstanding issue on the Ombi Discord currently