fix: chown the correct index.html path (dist/browser) — regression of #124 - #127
Merged
thespad merged 1 commit intoJun 6, 2026
Merged
Conversation
The Angular build output moved into a browser/ subfolder, so the index.html that Ombi rewrites for BASE_URL lives at dist/browser/index.html. Commit 32375bf reintroduced the pre-linuxserver#124 path (dist/index.html) while adding the LSIO_READ_ONLY_FS guard, so the real file is never chowned to abc and Ombi cannot apply BASE_URL (blank page behind a subpath reverse proxy). Restore the browser/ path inside the read-only guard. Closes linuxserver#126
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
thespad
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The init script chowns the wrong
index.htmlpath, so Ombi cannot applyBASE_URLand the UI shows a blank page behind a sub-path reverse proxy.The Angular build output moved into a
browser/subfolder; the file Ombi rewrites at startup lives at/app/ombi/ClientApp/dist/browser/index.html. PR #124 already fixed this, but commit 32375bf ("Fix subfolder permissions fix", which added theLSIO_READ_ONLY_FSguard) reintroduced the olddist/index.htmlpath. As a result the real file is never chowned toabc, the<base href>is never updated, and assets 404 from the domain root.This restores the
browser/path inside the existing read-only guard — keeping that guard intact.if [[ -z ${LSIO_READ_ONLY_FS} ]]; then - lsiown abc:abc /app/ombi/ClientApp/dist/index.html + lsiown abc:abc /app/ombi/ClientApp/dist/browser/index.html fiBenefits of this PR and context
Fixes the blank-page / "unauthorized access to index.html" startup error for sub-path (
BASE_URL) deployments on current images.Closes #126
How Has This Been Tested?
Verified against the published images: in
4.53.5(working)index.htmlsits atdist/index.html; in4.53.10it is atdist/browser/index.htmlwhile the chown still targetsdist/index.html, leaving the file owned by1001:1001and unwritable by theabc(PUID) user.Source / References
Type of change