fix: change default ambient brightness to off - #152
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the ambient brightness configuration so that the auto brightness feature is disabled by default, aligning behavior with product design while preserving existing user settings on upgrade. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 1.0.40 |
According to product design, the ambient light auto brightness feature should be disabled by default. This commit updates the default value of `ambientLightAdjustBrightness` from `true` to `false` in the configuration file. Log: Ambient brightness default changed to off Influence: 1. Verify that the ambient brightness switch is initially off on fresh install 2. Test manually enabling the feature and confirm it works as expected 3. Check that upgrading from a previous version does not override user's custom setting (if applicable) fix: 将自动亮度默认值改为关闭 根据产品设计,自动亮度功能默认应关闭。本次提交将配置项 `ambientLightAdjustBrightness` 的默认值从 `true` 改为 `false`。 Log: 自动亮度默认关闭 Influence: 1. 验证新安装系统下自动亮度开关默认关闭 2. 测试手动开启后功能是否正常 3. 检查从旧版本升级后,用户自定义设置是否被保留(如适用) PMS: BUG-372191
deepin pr auto review☀ ★ 总体评分:100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 --- a/src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json
+++ b/src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json
@@ -3,7 +3,7 @@
"version": "1.0",
"contents": {
"ambientLightAdjustBrightness": {
- "value": true,
+ "value": false,
"serial": 0,
"flags": [],
"name": "Ambient light auto brightness" |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
According to product design, the ambient light auto brightness feature should be disabled by default. This commit updates the default value of
ambientLightAdjustBrightnessfromtruetofalsein the configuration file.Log: Ambient brightness default changed to off
Influence:
fix: 将自动亮度默认值改为关闭
根据产品设计,自动亮度功能默认应关闭。本次提交将配置项
ambientLightAdjustBrightness的默认值从true改为false。Log: 自动亮度默认关闭
Influence:
PMS: BUG-372191
Summary by Sourcery
Bug Fixes: