Skip to content

fix: change default ambient brightness to off - #152

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
fly602:master
Aug 18, 2026
Merged

fix: change default ambient brightness to off#152
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
fly602:master

Conversation

@fly602

@fly602 fly602 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

According to product design, the ambient light auto brightness feature should be disabled by default. This commit updates the default value of ambientLightAdjustBrightness from true to false in the configuration file.

Log: Ambient brightness default changed to off

Influence:

  1. Verify that the ambient brightness switch is initially off on fresh install
  2. Test manually enabling the feature and confirm it works as expected
  3. Check that upgrading from a previous version does not override user's custom setting (if applicable)

fix: 将自动亮度默认值改为关闭

根据产品设计,自动亮度功能默认应关闭。本次提交将配置项
ambientLightAdjustBrightness 的默认值从 true 改为 false

Log: 自动亮度默认关闭

Influence:

  1. 验证新安装系统下自动亮度开关默认关闭
  2. 测试手动开启后功能是否正常
  3. 检查从旧版本升级后,用户自定义设置是否被保留(如适用)

PMS: BUG-372191

Summary by Sourcery

Bug Fixes:

  • Disable ambient brightness adjustment by default for fresh installations.

@sourcery-ai

sourcery-ai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the ambient brightness configuration so that the auto brightness feature is disabled by default, aligning behavior with product design while preserving existing user settings on upgrade.

File-Level Changes

Change Details Files
Change the default value of the ambient auto-brightness feature from enabled to disabled in configuration.
  • Update the ambientLightAdjustBrightness configuration default from true to false
  • Ensure default switch state is off on fresh installs while not altering existing user preferences on upgrade
src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot

deepin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 1.0.40
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #154

According to product design, the ambient light auto brightness feature
should be disabled by default. This commit updates the default value
of `ambientLightAdjustBrightness` from `true` to `false` in the
configuration file.

Log: Ambient brightness default changed to off

Influence:
1. Verify that the ambient brightness switch is initially off on fresh
install
2. Test manually enabling the feature and confirm it works as expected
3. Check that upgrading from a previous version does not override user's
custom setting (if applicable)

fix: 将自动亮度默认值改为关闭

根据产品设计,自动亮度功能默认应关闭。本次提交将配置项
`ambientLightAdjustBrightness` 的默认值从 `true` 改为 `false`。

Log: 自动亮度默认关闭

Influence:
1. 验证新安装系统下自动亮度开关默认关闭
2. 测试手动开启后功能是否正常
3. 检查从旧版本升级后,用户自定义设置是否被保留(如适用)

PMS: BUG-372191
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

☀ ★ 总体评分:100分

■ 【总体评价】

代码实现了环境光自动亮度默认配置的关闭,无任何缺陷
逻辑正确且无安全风险,符合满分标准

■ 【详细分析】

  • 1.语法逻辑(完全正确)✓

将JSON配置文件中的布尔值从true修改为false,符合JSON语法规范,逻辑表达准确
建议:无需改进

  • 2.代码质量(符合规范)✓

仅修改配置项的默认值,未涉及代码逻辑变更,符合配置文件管理规范
建议:无需改进

  • 3.代码性能(无性能问题)✓

静态配置文件的修改不引入任何运行时性能开销
建议:无需改进

  • 4.代码安全(存在0个安全漏洞)✓

漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个
修改配置项默认状态不引入任何安全风险,无攻击面

  • 建议:无需安全修复

■ 【改进建议代码示例】

--- a/src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json
+++ b/src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json
@@ -3,7 +3,7 @@
     "version": "1.0",
     "contents": {
         "ambientLightAdjustBrightness": {
-            "value": true,
+            "value": false,
             "serial": 0,
             "flags": [],
             "name": "Ambient light auto brightness"

@fly602

fly602 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot

deepin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit b7d95e1 into linuxdeepin:master Aug 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants