Skip to content

fix: change default ambient brightness to off - #156

Draft
fly602 wants to merge 1 commit into
release/2500from
fix/ambient-brightness-off-2500
Draft

fix: change default ambient brightness to off#156
fly602 wants to merge 1 commit into
release/2500from
fix/ambient-brightness-off-2500

Conversation

@fly602

@fly602 fly602 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Backport to release/2500

本次为提交 ffefe3d8(即 PR #152,"fix: change default ambient brightness to off")的 cherry-pick backport 到 release/2500 分支。

改动内容

将 DConfig 配置项 ambientLightAdjustBrightness 的默认值从 true 改为 false,即默认关闭环境光自动亮度功能(关联 PMS: BUG-372191)。

仅 1 个文件、1 行变更:

  • src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json
    • "value": true"value": false

DConfig meta 结构(magic/version/contents/serial/flags)保持完好,JSON 校验通过;运行时代码通过 DConfig 动态读取该键,默认值变更即可生效,无需改 cpp。

关联

说明

  • cherry-pick 保留原提交作者(fuleyi <fuleyi@uniontech.com>)与完整 commit message(含 PMS: BUG-372191),cherry-pick 无冲突。
  • 已通过代码审核(100 分 / 优秀 / Low 风险,0 条意见)。
  • 本 PR 为 draft / 待审核状态,合并由人工确认,请勿自动合并。

注:本 Multica issue(DDE-125)的 done 状态由用户人工确认,PR 合并不应自动关闭该 issue。

Summary by Sourcery

Bug Fixes:

  • Disable ambient-light automatic brightness by default by changing the DConfig default for ambientLightAdjustBrightness from enabled to disabled.

According to product design, the ambient light auto brightness feature
should be disabled by default. This commit updates the default value
of `ambientLightAdjustBrightness` from `true` to `false` in the
configuration file.

Log: Ambient brightness default changed to off

Influence:
1. Verify that the ambient brightness switch is initially off on fresh
install
2. Test manually enabling the feature and confirm it works as expected
3. Check that upgrading from a previous version does not override user's
custom setting (if applicable)

fix: 将自动亮度默认值改为关闭

根据产品设计,自动亮度功能默认应关闭。本次提交将配置项
`ambientLightAdjustBrightness` 的默认值从 `true` 改为 `false`。

Log: 自动亮度默认关闭

Influence:
1. 验证新安装系统下自动亮度开关默认关闭
2. 测试手动开启后功能是否正常
3. 检查从旧版本升级后,用户自定义设置是否被保留(如适用)

PMS: BUG-372191
@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sourcery-ai

sourcery-ai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Backports a single configuration change to release/2500 that turns off ambient light-based automatic brightness by default via a DConfig JSON update.

File-Level Changes

Change Details Files
Default ambient light auto-brightness behavior is changed from enabled to disabled via DConfig in the release/2500 branch.
  • Update the DConfig key ambientLightAdjustBrightness default value from true to false so ambient brightness adjustment is off by default.
  • Preserve existing DConfig JSON meta structure (magic/version/contents/serial/flags) and rely on runtime dynamic reading to pick up the new default without C++ code changes.
  • Cherry-pick the original master commit (PR fix: change default ambient brightness to off #152) into release/2500 with original author and commit message intact, ensuring a clean, conflict-free backport.
src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants