fix: change default ambient brightness to off - #156
Draft
fly602 wants to merge 1 commit into
Draft
Conversation
According to product design, the ambient light auto brightness feature should be disabled by default. This commit updates the default value of `ambientLightAdjustBrightness` from `true` to `false` in the configuration file. Log: Ambient brightness default changed to off Influence: 1. Verify that the ambient brightness switch is initially off on fresh install 2. Test manually enabling the feature and confirm it works as expected 3. Check that upgrading from a previous version does not override user's custom setting (if applicable) fix: 将自动亮度默认值改为关闭 根据产品设计,自动亮度功能默认应关闭。本次提交将配置项 `ambientLightAdjustBrightness` 的默认值从 `true` 改为 `false`。 Log: 自动亮度默认关闭 Influence: 1. 验证新安装系统下自动亮度开关默认关闭 2. 测试手动开启后功能是否正常 3. 检查从旧版本升级后,用户自定义设置是否被保留(如适用) PMS: BUG-372191
|
Skipping CI for Draft Pull Request. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBackports a single configuration change to release/2500 that turns off ambient light-based automatic brightness by default via a DConfig JSON update. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport to
release/2500本次为提交
ffefe3d8(即 PR #152,"fix: change default ambient brightness to off")的 cherry-pick backport 到release/2500分支。改动内容
将 DConfig 配置项
ambientLightAdjustBrightness的默认值从true改为false,即默认关闭环境光自动亮度功能(关联 PMS: BUG-372191)。仅 1 个文件、1 行变更:
src/plugin-qt/ambient-brightness/configs/org.deepin.dde.daemon.ambient-brightness.json"value": true→"value": falseDConfig meta 结构(
magic/version/contents/serial/flags)保持完好,JSON 校验通过;运行时代码通过 DConfig 动态读取该键,默认值变更即可生效,无需改 cpp。关联
master)说明
fuleyi <fuleyi@uniontech.com>)与完整 commit message(含PMS: BUG-372191),cherry-pick 无冲突。Summary by Sourcery
Bug Fixes:
ambientLightAdjustBrightnessfrom enabled to disabled.