Repository navigation
fix: consultation-popup - Open the popup from the CTA band and section buttons (LSA-214) - #162
Merged
brandonmarshal merged 2 commits intoOct 26, 2026
Conversation
brandonmarshal
added
comp:block-patterns
brandonmarshal
added
status:needs-review
Contributor
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
 |
| Layer / File(s) | Summary |
|---|---|
Add trigger classes to CTA patterns patterns/cta/*, patterns/sections/*, CHANGELOG.md |
CTA button block metadata and rendered wrappers gain pum-triggercta or pum-triggerbrief. Existing links and labels remain unchanged. The changelog records /free-consultation/ and /contact/ fallback links. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related issues
lightspeedwp/ls-theme#160: The issue requests Consultation popup triggers on redesigned pages. This PR adds the trigger to CTA band and section patterns.lightspeedwp/ls-theme#155: The issue covers the shared Website Brief popup trigger. This PR adds that trigger to two “Send a brief first” buttons.
Possibly related PRs
- lightspeedwp/ls-theme#161: This PR adds the same Consultation popup trigger to hero, header, and phase CTA buttons.
- lightspeedwp/ls-theme#142: This PR adds the CTA pattern that this PR updates with the Consultation popup trigger.
Suggested reviewers: zaredrogers
Merge Risk: 
d9fd0
-
No actionable issue was found in these CTA changes. Confirm popup activation and fallback behavior on the target site during normal release checks.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly describes the main change: opening the Consultation popup from CTA band and section buttons. It also includes the relevant issue identifier. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 13 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.
Comment @coderabbitai help to get the list of available commands.
brandonmarshal
added a commit
that referenced
this pull request
Oct 26, 2026
…SA-214) Changelog - Add the entry for the CTA band and section popup buttons - Note the Website Brief popup on the two "Send a brief first" buttons - Note that each button keeps its fallback link - Link the entry to PR #162 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 26, 2026
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
20 of 24 tasks
…n buttons (LSA-214) Consultation trigger - Add the pum-triggercta class to the consultation button in 8 CTA band patterns - Cover cta-dark-band-buttons, the five section-cta-consultation and split-checklist patterns, split-cta-check-card and split-cta-tile-band - Add it to the buttons in blog-writing-cta, homepage-cta, phase-support-focus, services-cta and work-discuss-project Brief trigger - Add the pum-triggerbrief class to the "Send a brief first" buttons in homepage-cta and work-discuss-project - Keep their /contact/ link as the fallback Fallback - Keep every button's existing link, so the button still works if the popup or JavaScript fails - Put the class on the wp-block-button wrapper, as in the existing trigger patterns Left unchanged - Leave the "Explore related work", "See discovery in practice" and "Explore our services" links as plain links - Add no new SCSS, tokens or styles
…SA-214) Changelog - Add the entry for the CTA band and section popup buttons - Note the Website Brief popup on the two "Send a brief first" buttons - Note that each button keeps its fallback link - Link the entry to PR #162 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
brandonmarshal
force-pushed
the
fix/lsa-214-popup-cta-buttons
branch
from
October 26, 2026 12:09
d9fd026 to
669ca54
Compare
ZaredRogers
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix Pull Request
Stack
fix/lsa-214-popup-hero-buttons), so the diff below is just this layer. Once fix: consultation-popup - Open the Consultation popup from the hero, header and phase CTA buttons (LSA-214) #161 merges, the base is changed todevelop.Linked issues
Relates to #160 and Linear LSA-214 (improve: consultation-popup). It does not close the issue: PR 3, the inline Form 4 on
/free-consultation/and the DEV page content are still open.Context
/free-consultation/as its source page instead of the page the visitor was on.Reproduction
/services/discovery/. 2) Click the "Book a free consultation" button./free-consultation/.Root Cause
The consultation buttons in these CTA and section patterns are plain links to
/free-consultation/. The Consultation popup (Popup Maker popup 48606, Form 4) already loads on every DEV page and opens from the CSS selector.pum-triggercta, but none of these buttons carries that class. The "Send a brief first" buttons likewise do not open the Website Brief popup (selector.pum-triggerbrief).Fix Summary
PR 2 of 3: CTA bands and sections. It adds
pum-triggerctato the consultation button in 13 patterns, andpum-triggerbriefto two brief buttons, and keeps every button's existing link as the fallback.cta-dark-band-buttons,section-cta-consultation-band,section-cta-consultation-inline,section-cta-consultation-reassurance,section-cta-consultation-strip,section-cta-split-checklist,split-cta-check-card,split-cta-tile-band.blog-writing-cta,homepage-cta,phase-support-focus("Request Assessment"),services-cta,work-discuss-project.homepage-ctaandwork-discuss-projectgetpum-triggerbrief. Their/contact/link is kept as the fallback, so their destination is unchanged.wp-block-buttonwrapper, as in the existing trigger patterns. Eachwp:buttonblock comment and its rendered class are updated together.Scope and exclusions
/free-consultation/, and updating the existing DEV page content. Pages built from these patterns keep their own copy of the old buttons until their content is updated.CHANGELOG.md), 30 added and 30 removed lines in the patterns. No generated files.Verification
/free-consultation/. Desktop only; the buttons were spot-checked, not every one individually.php -landvendor/bin/phpcspass for the 13 patternsnpm run patterns:escape,npm run lint:jsonandnpm run security:scanpassRisk & Rollback
Changelog
meta:needs-changelog: restores the popup behaviour from the CTA band and section buttons. The entry is inCHANGELOG.mdon this branch.Changed
Checklist (Global DoD / PR)
patterns:escapeclean)🤖 Generated with Claude Code
Summary by CodeRabbit