Enforce Oxford spelling#74
Conversation
Add the shared spelling-policy helper, cached base dictionary, pinned typos gate, and CI integration. Correct all genuine corpus findings while retaining documented local terminology.\n\nRepair the strict test lint surface and stale release target exposed by the full repository gates.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @leynos, your pull request is larger than the review limit of 150000 diff characters
|
Caution Review failedAn error occurred during the review process. Please try again later. Summary
ValidationFormatting, linting, type checking, workflow contract tests, full tests, release, Markdown linting, Nixie, Makefile validation, actionlint, and whitespace checks pass. WalkthroughIntroduces generated Typos configuration from shared and local dictionaries, adds cache refresh and fallback handling, wires spelling checks into Make and CI, updates repository documentation, and improves test error propagation. ChangesSpelling policy rollout
Possibly related issues
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 613524e341
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @$(UV_ENV) $(UV) run scripts/generate_typos_config.py | ||
| @git ls-files -z '*.md' | \ | ||
| xargs -0 -r env $(UV_ENV) $(UV) tool run typos@$(TYPOS_VERSION) \ | ||
| --config typos.toml --force-exclude |
There was a problem hiding this comment.
When a PR changes typos.local.toml or the shared dictionary advances, this target rewrites the tracked typos.toml and then immediately runs typos against that uncommitted output. Because the recipe never checks git diff --exit-code typos.toml after regeneration, CI can pass while the committed generated config remains stale, leaving fresh or offline checkouts to use a different spelling policy than the one CI validated.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 613524e341
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @$(UV_ENV) $(UV) run scripts/generate_typos_config.py | ||
| @git ls-files -z '*.md' | \ | ||
| xargs -0 -r env $(UV_ENV) $(UV) tool run typos@$(TYPOS_VERSION) \ | ||
| --config typos.toml --force-exclude |
There was a problem hiding this comment.
When a PR changes typos.local.toml or the shared dictionary advances, this target rewrites the tracked typos.toml and then immediately runs typos against that uncommitted output. Because the recipe never checks git diff --exit-code typos.toml after regeneration, CI can pass while the committed generated config remains stale, leaving fresh or offline checkouts to use a different spelling policy than the one CI validated.
Useful? React with 👍 / 👎.
1 participant
Summary
typos.tomlfrom the shared dictionary plus a narrow local overlaytyposchecks locally and in CIValidation
make check-fmtmake lintmake typecheckmake test-workflow-contracts(6 passed)make test(all targets and features passed)make releasemake markdownlint(shared helper: 15 passed, 90.94% coverage)make nixiembake validate Makefileactionlint .github/workflows/ci.ymlgit diff --checkScope note
The 27-file change exceeds the normal twelve-file tolerance because 52 required spelling corrections span 13 existing prose files, alongside the standard shared-policy integration files. The local overlay accepts only the
HashiCorpproper name and the deliberate model termmis-predictions.No linked issue or repository roadmap item was found for this estate-wide maintenance rollout.