Skip to content

Add polymer to the shared Oxford authority#61

Merged
leynos merged 2 commits into
mainfrom
typos-polymer-stem
Jul 15, 2026
Merged

Add polymer to the shared Oxford authority#61
leynos merged 2 commits into
mainfrom
typos-polymer-stem

Conversation

@leynos

@leynos leynos commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

This branch adds the polymer stem to the shared Oxford authority so correct
polymerization forms are accepted and plain-British variants are corrected
consistently. It records Dakar's reclassification as the rollout's 97th
candidate and regenerates the tracked consumer policy deterministically.

No repository issue, roadmap task, or repository ExecPlan applies to this
focused shared-authority update.

Review walkthrough

Validation

  • make ci: green; 185 tests and three snapshots pass.
  • Markdownlint: green.
  • Mbake: green.
  • Typos 1.48 spelling and prohibited-phrase checks: green.
  • Two canonical regenerations are byte-identical.
  • TOML and semantic audit: exactly one authority stem, ten Oxford identity
    mappings, and ten plain-British corrections; no existing mapping changes.

Notes

The repository has no Nixie target, and the documentation change adds no
Mermaid diagram.

Accept Oxford `polymerization` forms and correct their plain-British
counterparts through the shared generated dictionary. Record Dakar's inclusion
as the 97th rollout candidate and keep the generated consumer policy
deterministic.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 48 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b27ea9c4-4d58-43d6-802c-f50eee5d4139

📥 Commits

Reviewing files that changed from the base of the PR and between 8a9ac90 and 298eff8.

📒 Files selected for processing (4)
  • data/typos-oxendict-base.toml
  • docs/developers-guide.md
  • tests/test_typos_rollout.py
  • typos.toml

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Add Oxford stem data and en-GB correction mappings for the polymer word family. Extend rollout tests for polymerization and document the associated Oxford-stemming audit.

Changes

Polymer spelling support

Layer / File(s) Summary
Add polymer dictionary mappings
data/typos-oxendict-base.toml, typos.toml
Add the polymer Oxford stem and map UK polymer spellings to canonical polymer* forms.
Validate and document polymer support
tests/test_typos_rollout.py, docs/developers-guide.md
Assert Oxford acceptance and correction of polymerization, then record the Dakar curation audit.

Possibly related PRs

Poem

Add polymer stems in line,
Map UK forms to US design.
Test each spelling, clear and bright,
Record the audit’s dated sight.
Let every polymer word align.

🚥 Pre-merge checks | ✅ 19 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
User-Facing Documentation ⚠️ Warning docs/users-guide.md covers the spelling workflow, but it never mentions the new polymer/polymerization authority update or the plain-British correction behaviour. Add a brief note in docs/users-guide.md under Shared spelling tools explaining that the shared Oxford base now accepts polymerization and normalises polymerise/polymerisation variants.
✅ Passed checks (19 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the polymer stem addition to the shared Oxford authority.
Description check ✅ Passed The description directly matches the stem, spelling, documentation, and validation changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Testing (Overall) ✅ Passed The new polymerization regression test exercises the real generator against the curated dictionary and would fail if the stem or correction were omitted or inverted.
Developer Documentation ✅ Passed PASS: docs/developers-guide.md records the new polymer stem and Dakar audit; no roadmap, execplan, or locale docs need syncing.
Module-Level Documentation ✅ Passed tests/test_typos_rollout.py already has a module docstring; the other changed files are TOML/Markdown, not modules.
Testing (Unit And Behavioural) ✅ Passed PASS: The new assertions extend an existing public mapping test, and the committed-config check already covers the generated artefact; no hidden mocks or missing boundary.
Testing (Property / Proof) ✅ Passed The change is a data-only stem addition; the existing Hypothesis test already covers the stem/suffix invariant, so no new property/proof recommendation is needed.
Testing (Compile-Time / Ui) ✅ Passed No Rust/TypeScript compile-time surface is touched; the Python tests use focused assertions and deterministic config equality, so trybuild/snapshots are not required here.
Unit Architecture ✅ Passed PASS: The PR only updates dictionary data, generated config, docs, and a read-only behavioural test; it adds no new side-effects, hidden dependencies, or mixed-responsibility code.
Domain Architecture ✅ Passed Only typo dictionary, tests, and docs changed; no domain, transport, persistence, or infrastructure boundary was altered.
Observability ✅ Passed PASS: this PR only curates spelling data, docs, and tests; no runtime code, logging, metrics, tracing, or alerts changed.
Security And Privacy ✅ Passed Approve: the patch only adds a spelling stem, test coverage, generated mappings, and a doc note; no secrets, auth, permissions, or sensitive data appear.
Performance And Resource Use ✅ Passed Only static dictionary, test, and doc entries changed; no runtime loops, I/O, or memory-growth paths were added.
Concurrency And State ✅ Passed PASS: The PR only adds a dictionary stem, docs note, generated spellings, and a deterministic test; no new shared mutable state, async tasks, or locking paths were introduced.
Architectural Complexity And Maintainability ✅ Passed PASS: The patch only updates dictionary data, a doc note, a test, and generated config; it adds no new layers, indirection, registries, or dependencies.
Rust Compiler Lint Integrity ✅ Passed No Rust files changed; the diff only touches TOML, docs, and a Python test, so no lint suppressions or clone regressions were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch typos-polymer-stem

Comment @coderabbitai help to get the list of available commands.

@leynos
leynos marked this pull request as ready for review July 15, 2026 10:38
@leynos

leynos commented Jul 15, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/test_typos_rollout.py`:
- Line 30: Annotate the PLAIN_BRITISH_POLYMERIZATION constant with the str type
while preserving its existing value and construction.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 42face31-5a42-4a3d-aabb-6c306f88916e

📥 Commits

Reviewing files that changed from the base of the PR and between 8a9ac90 and bd1b0e7.

📒 Files selected for processing (4)
  • data/typos-oxendict-base.toml
  • docs/developers-guide.md
  • tests/test_typos_rollout.py
  • typos.toml

Comment thread tests/test_typos_rollout.py Outdated
Make the new fixture constant's string type explicit while preserving its split spelling construction.
@leynos

leynos commented Jul 15, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.


You're currently rate limited under our Fair Usage Limits Policy. Your recent PR review activity is in the 95th percentile or higher among CodeRabbit users, so adaptive limits apply. Your next review will be available in 48 minutes.

@leynos
leynos merged commit 3c90b2f into main Jul 15, 2026
5 checks passed
@leynos
leynos deleted the typos-polymer-stem branch July 15, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant