Repository navigation
feat: Add the override marker to the flag and segment models and mark evaluations - #221
kinyoklion wants to merge 4 commits into
Conversation
f0038ed to
79250a7
Compare
1ba722a to
996b8d3
Compare
|
bugbot review |
996b8d3 to
ca22bc0
Compare
|
bugbot review |
|
bugbot review |
64740d7 to
a4d9c28
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a4d9c28. Configure here.
… evaluations The OVERRIDE specification requires an evaluation to be marked as override-affected when any definition it read carried the override marker: the evaluated flag, a prerequisite at any depth, or a segment consulted during matching, whether or not the segment matched. The marking propagates upward only. A prerequisite's own record reflects only the definitions that its own subtree read. An evaluation that fails is still marked when it read a marked definition. DataModel.FeatureFlag and DataModel.Segment carry a transient isOverride marker that is never serialized and never read from JSON, with a markedAsOverride() shallow copy that the override layer will use without modifying the source's entity. The evaluator tracks the marking per evaluation scope: the scope starts from its own flag's marker, each segment read can set it, and the value is saved, reset to the prerequisite's marker, and restored around each prerequisite evaluation. The result and every prerequisite record carry the marking on their reason. EvalResult exposes isOverrideAffected() and withOverrideAffected(), which copies rather than mutating the shared precomputed results. A requested-type mismatch keeps the marking on its error reason. The server SDK now depends on launchdarkly-java-sdk-common 2.6.0, which adds the overrideAffected indicator to EvaluationReason. CI for this change cannot pass until that version is released. Flag overrides are currently experimental and subject to change.
…gnized stage migrationVariation replaces the result of a flag that serves an unrecognized stage with a WRONG_TYPE error. The evaluation read the same definitions, so the replacement keeps the override-affected marking, as the type mismatch of an ordinary variation call already does, and the migration tracker receives a marked reason for an overridden flag.
When the evaluation of a flag throws, the error result now carries the override-affected marking of the flag's own definition, which was read before the failure. The spec marks a failed evaluation when a definition it read came from the override store.
When the evaluation of a flag throws inside allFlagsState, the state now records the error reason with the override-affected marking of the flag's own definition, as the single-flag path already does.
5eee1ed to
2ac73fd
Compare
3b81e47 to
68f868e
Compare
There was a problem hiding this comment.
Stale comment
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: Override-affected marking is wired through the server SDK evaluator, flag/segment data model, and error/mismatch wrappers (
Evaluator.java,DataModel.java,InputValidatingEvaluator.java,MigrationStageEnforcingEvaluator.java), plus alaunchdarkly-java-sdk-common2.6.0 bump, so correctness spans several interacting evaluation paths.Human review is needed and no reviewers were assigned.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
There was a problem hiding this comment.
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: Override-affected marking is threaded through DataModel, Evaluator, InputValidatingEvaluator, and MigrationStageEnforcingEvaluator, plus a launchdarkly-java-sdk-common 2.6.0 bump, so evaluation behavior depends on several interacting pieces. Tests cover the new paths, but this is not a narrow change.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver



Update, 2026-11-13
feat/overrides, which now includes feat: Add the overrideAffected indicator to EvaluationReason #218 and feat: Count override-affected evaluations separately and send no individual events for them #219 and hasmainmerged into it. Frommainit gets the 7.18.0 release, CI on the latest v3 contract tests, flag change listener support in the contract test service, and thejava-sdk-internal1.12.1 and 1.12.2 fixes. A common 2.6.0 and internal 1.13.0 release from this branch needs those fixes.main, both resolved by keeping both sides:Evaluator.java:main's fix: Include the big segments status on evaluation reasons when a flag fails to evaluate #258 keeps the big segments status on an error reason, and this PR marks that result as override-affected.build.gradle:main'sjsr305and internal 1.12.2, with this PR's common 2.6.0.commonandinternalpublished locally fromfeat/overrides:Summary
The OVERRIDE specification requires an evaluation to be marked as override-affected when any definition it read carried the override marker: the evaluated flag, a prerequisite at any depth, or a segment consulted during matching, whether or not the segment matched. The marking propagates upward only: a prerequisite's own record reflects only the definitions that its own subtree read, while the evaluation that requested it accumulates the result. An evaluation that fails is still marked when it read a marked definition, and a requested-type mismatch keeps the marking on its error reason, as does the WRONG_TYPE error that
migrationVariationreturns for an unrecognized stage.DataModel.FeatureFlagandDataModel.Segmentcarry a transientisOverridemarker. It is never serialized and never read from JSON.markedAsOverride()returns a shallow copy with the marker set, sharing nested collections and preprocessing with the source and never modifying it. The override layer will use it in the next change.EvalResult.isOverrideAffected()reads the reason's indicator, andwithOverrideAffected(boolean)returns a copy so that the shared precomputed results are never mutated.EXCEPTIONresult marked with the evaluated flag's own marker, because that definition was read before the failure.EvaluationReason.isOverrideAffected()and theoverrideAffectedJSON property (written only when true). CI for this change cannot pass until that version is released.Flag overrides are currently experimental and subject to change.
This PR is based on the file data reliability branch (rlamb/overrides-java-filedata-reloader) so the series applies in order; retarget it to feat/overrides once that branch merges.
The existing file data source keeps its current behavior; this change does not touch its code paths.
SDK-3246
Note
Overview
Introduces experimental flag-override tracking by adding a transient
isOverridemarker onFeatureFlagandSegment(viamarkedAsOverride()shallow copies that never serialize to JSON), and bumping launchdarkly-java-sdk-common to 2.6.0 soEvaluationReasoncan exposeoverrideAffected.The evaluator now tracks per-scope whether any read definition was overridden—the evaluated flag, nested prerequisites, or segments consulted during matching (match or not)—and stamps that on the result reason with upward-only propagation (each prerequisite record keeps its own subtree marking). EvalResult gains
isOverrideAffected()/withOverrideAffected()without mutating shared precomputed results.InputValidatingEvaluator, MigrationStageEnforcingEvaluator, and allFlagsState preserve the marker on errors, type mismatches, and exceptions when an override flag was already loaded. Broad unit tests cover model serialization, propagation, and edge cases.
Reviewed by Cursor Bugbot for commit 2ac73fd. Bugbot is set up for automated code reviews on this repo. Configure here.
Opened from termag