Skip to content

Commit 2ac73fd

Browse files
committed
fix: Mark the EXCEPTION result of an overridden flag in allFlagsState
When the evaluation of a flag throws inside allFlagsState, the state now records the error reason with the override-affected marking of the flag's own definition, as the single-flag path already does.
1 parent 13dce52 commit 2ac73fd

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

‎lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/InputValidatingEvaluator.java‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,10 @@ public FeatureFlagsState allFlagsState(LDContext context, FlagsStateOption... op
208208
logger.error("Exception caught for feature flag \"{}\" when evaluating all flags: {}", flag.getKey(),
209209
LogValues.exceptionSummary(e));
210210
logger.debug(e.toString(), LogValues.exceptionTrace(e));
211-
builder.addFlag(flag, EvalResult.of(LDValue.ofNull(), NO_VARIATION, EvaluationReason.exception(e)));
211+
// The flag's definition was read before the failure, so its own marker decides the marking,
212+
// and with it the state's event tracking fields for the flag.
213+
builder.addFlag(flag, EvalResult.of(LDValue.ofNull(), NO_VARIATION, EvaluationReason.exception(e))
214+
.withOverrideAffected(flag.isOverride()));
212215
}
213216
}
214217
return builder.build();

‎lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/InputValidatingEvaluatorOverrideTest.java‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,4 +167,17 @@ public void allFlagsStateKeepsMarkedReason() {
167167
Map.Entry<String, LDValue> expected = new AbstractMap.SimpleEntry<>("marked", LDValue.of("x"));
168168
assertEquals(expected.getValue(), state.getFlagValue("marked"));
169169
}
170+
171+
@Test
172+
public void allFlagsStateMarksTheExceptionOfAnOverrideFlag() {
173+
FeatureFlag marked = flagWithPrerequisite("marked").markedAsOverride();
174+
FeatureFlag plain = flagWithPrerequisite("plain");
175+
FeatureFlagsState state = evaluatorOver(storeFailingOn("prereq", marked, plain))
176+
.allFlagsState(BASE_USER, FlagsStateOption.WITH_REASONS);
177+
178+
assertEquals(ErrorKind.EXCEPTION, state.getFlagReason("marked").getErrorKind());
179+
assertTrue(state.getFlagReason("marked").isOverrideAffected());
180+
assertEquals(ErrorKind.EXCEPTION, state.getFlagReason("plain").getErrorKind());
181+
assertFalse(state.getFlagReason("plain").isOverrideAffected());
182+
}
170183
}

0 commit comments

Comments
 (0)