Fix Transformer_NonRecursive crashing when root node is discarded#1614
Open
gaoflow wants to merge 1 commit into
Open
Fix Transformer_NonRecursive crashing when root node is discarded#1614gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
…scarded When the root tree node's callback returns Discard, the stack is left empty and the unpacking `result, = stack` raises ValueError. The recursive Transformer.transform() handles this by returning None; apply the same guard here. Fixes lark-parser#1611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Transformer_NonRecursive.transform()raisesValueError: not enough values to unpack (expected 1, got 0)when the root tree node's callback returnsDiscard.The regular
Transformerhandles this correctly by returningNonewhen the root is discarded (seeTransformer.transform()lines 161–163).Fix
Add the same empty-stack guard to
Transformer_NonRecursive.transform()before the destructuring assignment.Two-line change in
lark/visitors.py+ a regression test intests/test_trees.py.