Route WSL Lavish sessions through Windows runtime - #2833
Conversation
Confidence Score: 3/5The PR should not merge until server identity is validated before suppressing startup and registration upgrades preserve or roll back bindings atomically. A fixed-port collision can prevent every routed WSL lifecycle operation from reaching the intended server, and a binding-restoration failure can leave an upgraded persistent poll active without an answer destination. Files Needing Attention: bin/fm-lavish-windows.ps1, bin/fm-procevent-lavish.sh Reviews (1): Last reviewed commit: "fix(lavish): restore legacy poll after f..." | Re-trigger Greptile |
| function Ensure-LavishServer([string]$Lavish) { | ||
| if (Test-LavishPort) { | ||
| return |
There was a problem hiding this comment.
| if [ "$upgraded" -eq 1 ]; then | ||
| rm -f -- "$backup" | ||
| restore_binding "$id" "$binding" \ | ||
| || die "cannot restore the answer binding after upgrading: $id" |
There was a problem hiding this comment.
Binding failure loses rollback state
When replacement registration succeeds but restore_binding fails, this branch has already deleted the backup and exits with the routed poll registered but unbound, so completed captain answers cannot reach the keyed-answer intake and the previous registration cannot be restored.
Summary
Tests
bash tests/fm-lavish-route.test.shbash tests/fm-lavish-windows-argv.test.shbash tests/fm-procevent.test.shbin/fm-lint.shgit diff --check