Skip to content

Route WSL Lavish sessions through Windows runtime - #2833

Closed
Ikha14 wants to merge 9 commits into
kunchenguid:mainfrom
Ikha14:fm/repair-lavish-pr-v2
Closed

Route WSL Lavish sessions through Windows runtime#2833
Ikha14 wants to merge 9 commits into
kunchenguid:mainfrom
Ikha14:fm/repair-lavish-pr-v2

Conversation

@Ikha14

@Ikha14 Ikha14 commented Aug 23, 2026

Copy link
Copy Markdown

Summary

  • reconstruct the eight accepted commits from Route WSL Lavish sessions through Windows runtime #2815 on a clean branch
  • preserve WSL-to-Windows Lavish lifecycle routing and PowerShell 5.1 argv handling
  • restore the prior valid process-event registration when legacy poll replacement publication fails

Tests

  • bash tests/fm-lavish-route.test.sh
  • bash tests/fm-lavish-windows-argv.test.sh
  • bash tests/fm-procevent.test.sh
  • bin/fm-lint.sh
  • git diff --check

@greptile-apps

greptile-apps Bot commented Aug 23, 2026

Copy link
Copy Markdown

Confidence Score: 3/5

The PR should not merge until server identity is validated before suppressing startup and registration upgrades preserve or roll back bindings atomically.

A fixed-port collision can prevent every routed WSL lifecycle operation from reaching the intended server, and a binding-restoration failure can leave an upgraded persistent poll active without an answer destination.

Files Needing Attention: bin/fm-lavish-windows.ps1, bin/fm-procevent-lavish.sh

Reviews (1): Last reviewed commit: "fix(lavish): restore legacy poll after f..." | Re-trigger Greptile

Comment thread bin/fm-lavish-windows.ps1
Comment on lines +88 to +90
function Ensure-LavishServer([string]$Lavish) {
if (Test-LavishPort) {
return

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Foreign listener bypasses startup

If another Windows process is listening on 127.0.0.1:4388, Ensure-LavishServer accepts the TCP connection without verifying the listener and skips starting Lavish, causing routed open, poll, end, export, and share operations to fail against the wrong process.

Comment on lines +157 to +160
if [ "$upgraded" -eq 1 ]; then
rm -f -- "$backup"
restore_binding "$id" "$binding" \
|| die "cannot restore the answer binding after upgrading: $id"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Binding failure loses rollback state

When replacement registration succeeds but restore_binding fails, this branch has already deleted the backup and exits with the routed poll registered but unbound, so completed captain answers cannot reach the keyed-answer intake and the previous registration cannot be restored.

@Ikha14 Ikha14 closed this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant