Skip to content

Route WSL Lavish sessions through Windows runtime - #2815

Closed
Ikha14 wants to merge 8 commits into
kunchenguid:mainfrom
Ikha14:fm/lavish-windows-runtime-route
Closed

Route WSL Lavish sessions through Windows runtime#2815
Ikha14 wants to merge 8 commits into
kunchenguid:mainfrom
Ikha14:fm/lavish-windows-runtime-route

Conversation

@Ikha14

@Ikha14 Ikha14 commented Aug 22, 2026

Copy link
Copy Markdown

Summary

  • route WSL Lavish lifecycle operations through one Windows runtime and state store
  • preserve paths and argv, including empty and stop-style arguments across PowerShell 5.1
  • retain native non-WSL behavior and deterministic prerequisite failures

Tests

  • bash tests/fm-lavish-route.test.sh
  • bash tests/fm-lavish-windows-argv.test.sh

@greptile-apps

greptile-apps Bot commented Aug 22, 2026

Copy link
Copy Markdown

Confidence Score: 4/5

The PR should not merge until a failed legacy poll upgrade preserves or restores the prior registration instead of silently disabling board supervision.

The upgrade path stops and deletes the existing poll before its replacement is durably published, so a realistic registration failure leaves captain answers without a supervised poll.

Files Needing Attention: bin/fm-procevent-lavish.sh

Reviews (1): Last reviewed commit: "Fix PowerShell empty Lavish arguments" | Re-trigger Greptile

Comment on lines +131 to +132
"$SCRIPT_DIR/fm-procevent.sh" retire "$id" >/dev/null \
|| die "cannot retire the legacy Lavish poll registration: $id"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Legacy poll registration is lost

When replacement registration fails after a legacy source is retired, this upgrade deletes the old source and stops its runner while restoring only the answer binding, causing subsequent board answers to remain unsupervised.

@Ikha14

Ikha14 commented Aug 23, 2026

Copy link
Copy Markdown
Author

Superseded by the clean replacement PR #2833, which reconstructs the eight accepted commits and fixes the Greptile-reported legacy registration rollback defect.

@Ikha14 Ikha14 closed this Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant