Route WSL Lavish sessions through Windows runtime - #2815
Closed
Ikha14 wants to merge 8 commits into
Closed
Conversation
Confidence Score: 4/5The PR should not merge until a failed legacy poll upgrade preserves or restores the prior registration instead of silently disabling board supervision. The upgrade path stops and deletes the existing poll before its replacement is durably published, so a realistic registration failure leaves captain answers without a supervised poll. Files Needing Attention: bin/fm-procevent-lavish.sh Reviews (1): Last reviewed commit: "Fix PowerShell empty Lavish arguments" | Re-trigger Greptile |
Comment on lines
+131
to
+132
| "$SCRIPT_DIR/fm-procevent.sh" retire "$id" >/dev/null \ | ||
| || die "cannot retire the legacy Lavish poll registration: $id" |
Author
|
Superseded by the clean replacement PR #2833, which reconstructs the eight accepted commits and fixes the Greptile-reported legacy registration rollback defect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
bash tests/fm-lavish-route.test.shbash tests/fm-lavish-windows-argv.test.sh