Conversation
…) fix, take 2 Previous attempt (PR #948) pointed at quay.io/kubescape/storge (typo'd repo name from a pre-existing bug in kubescape/storage's manual build-image workflow) which turned out private-by-default, causing a total image-pull failure unrelated to the actual fix. This retry uses a corrected build pushed to the real, public quay.io/kubescape/storage repo under a private test tag (does not touch :latest). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LLN3CgGftcnAikV13qD6yJ
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe component-test workflow now uses the experimental storage image tag ChangesComponent test storage override
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Component tests now use the specified experimental storage image for isolated validation. No concrete merge-blocking risk remains in the current change. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Result: 15/30 failed (build-and-push-image succeeded, so 15/30 test jobs, 19/32 total including infra jobs). Real, substantial improvement over the 18-19/30 baseline — no more sustained 20-min hangs, storage deployment comes up cleanly, individual container-profile writes went from minutes-long timeouts to 5-9 seconds for a 16-item burst. But not the hoped-for near-zero. Traced the residual failures: still occasional Follow-up experiment testing higher shard/pool headroom (16 shards / 24 pool connections) in #950 before concluding whether this needs a higher default or has a separate contributing cause. |
Purpose
This is a validation experiment, not a proposed fix — do not merge.
Retry of #948, which was a false negative: that attempt's test image landed in
quay.io/kubescape/storge(typo'd repo name from a pre-existing bug in kubescape/storage's manualbuild-imageworkflow), which turned out to be a brand-new, private-by-default repo. The Kind cluster couldn't pull it at all — the storage deployment never became ready, so all 31 test jobs failed on infrastructure grounds, not on anything related to the write-throughput regression.This retry uses a corrected build (
quay.io/kubescape/storage:test-sharded-writer-397b— confirmed public viacurl https://quay.io/api/v1/repository/kubescape/storage/tag/with no auth), built from kubescape/storage#397'sfix/single-writer-sharded-commitsvia a throwaway build-workflow branch that fixes the repo-name typo and drops the:latesttag push so the real published tag is never touched.Expected result: near-zero failures, matching the pre-regression baseline, since the fix restores per-key write parallelism (default 8 shards) while keeping every existing single-writer correctness guarantee.
Test plan
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01LLN3CgGftcnAikV13qD6yJ
AI-skills: none | cmds: /oh-my-claudecode:autopilot
Summary by CodeRabbit