Skip to content

[EXPERIMENT] Validate real kubescape/storage v0.0.333 release - #951

Closed
matthyx wants to merge 1 commit into
mainfrom
experiment/validate-storage-v0.0.333-release
Closed

matthyx wants to merge 1 commit into
mainfrom
experiment/validate-storage-v0.0.333-release

Conversation

@matthyx

@matthyx matthyx commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Purpose

Throwaway validation PR — do not merge.

Prior validations (#949, #950) used a manually-built test image from the kubescape/storage#397 fix branch. That PR has since merged and released as v0.0.333, and kubescape/helm-charts main now points storage.image.tag at it.

This PR makes no functional change — tests/scripts/storage-tag.sh's normal dynamic resolution will pick up v0.0.333 on its own. Opening this purely to trigger component-tests and confirm the real, merged, released fix behaves the same as the manually-built validation image did (expect ~15/30 failures, down from the 18-19/30 baseline, no sustained hangs).

Test plan

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01LLN3CgGftcnAikV13qD6yJ

AI-skills: oh-my-claudecode:cancel | cmds: /oh-my-claudecode:autopilot

Summary by CodeRabbit

  • Tests
    • Added a validation-only update to component test workflow configuration. No user-facing product behavior has changed.

…333 release

Prior validations (node-agent#949, #950) used a manually-built test
image from the storage fix branch. This is a throwaway PR to confirm
component-tests pass against the actual released, merged version
(v0.0.333) that helm-charts now points at, via the normal dynamic
storage-tag.sh resolution -- no chart/workflow overrides needed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LLN3CgGftcnAikV13qD6yJ
@matthyx matthyx added the ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin) label Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 71e4c11a-95b3-44bb-8cd1-25368a7aa1cc

📥 Commits

Reviewing files that changed from the base of the PR and between 1c450e5 and daeb99a.

📒 Files selected for processing (1)
  • .github/workflows/component-tests.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The component test workflow adds a comment-only note to the Node Agent chart installation step. The note records validation against the released kubescape/storage v0.0.333 image.

Changes

Component Test Validation

Layer / File(s) Summary
Workflow validation note
.github/workflows/component-tests.yaml
The Node Agent chart installation step includes a comment-only no-op block that documents the validation target.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to daeb9

This change only documents the released storage-image validation target and does not change runtime or deployment behavior. No merge-blocking risk remains.

Suggested reviewers: entlein

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the validation experiment and the specific kubescape/storage v0.0.333 release tested by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch experiment/validate-storage-v0.0.333-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthyx

matthyx commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Result: 17 failed / 32 total — consistent with #949's earlier manually-built-image validation (15/30), within normal CI run-to-run variance.

Spot-checked the slowest failures (several jobs ran 1000-1265s, closer to the 20-min window than #949's failures): confirmed these are ordinary assertion failures (Not equal, Received unexpected error) from naturally long-running tests, not a regression back to the original sustained context deadline exceeded hang. The fix holds against the real, merged, released v0.0.333 — not just the manually-built validation image.

Confirms: kubescape/storage#397 is doing its job in production. Residual ~15-17/30 flakiness (vs the historical 0-1/30 baseline) remains a separate, smaller issue — not blocking, tracked as a follow-up (leading candidates from earlier investigation: storage pod's 500m CPU limit under load, or CI pod churn/restarts).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant