Skip to content

[EXPERIMENT] Validate kubescape/storage#397 (sharded single-writer) fix - #948

Closed
matthyx wants to merge 1 commit into
mainfrom
experiment/sharded-storage-writer-validation
Closed

matthyx wants to merge 1 commit into
mainfrom
experiment/sharded-storage-writer-validation

Conversation

@matthyx

@matthyx matthyx commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Purpose

This is a validation experiment, not a proposed fix — do not merge.

Points the test storage deployment at a manually-built image (quay.io/kubescape/storge:test-sharded-writer-397 — note: pre-existing typo in kubescape/storage's build-image workflow pushes to storge, not storage), built from kubescape/storage#397 (fix/single-writer-sharded-commits), to empirically confirm the sharded single-writer fix resolves this repo's component-tests regression (18-19 of ~30 matrix jobs failing since storage's singleWriterEnabled default flipped to true, see #397's description for the full root-cause writeup) before that PR merges upstream.

Expected result: near-zero failures, matching the pre-regression baseline, since the fix restores per-key write parallelism (default 8 shards) while keeping every existing single-writer correctness guarantee.

Test plan

  • component-tests run on this PR — compare failure count against the current baseline (18-19/30 failing) and the unmodified-storage-image baseline (0-1/30)

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01LLN3CgGftcnAikV13qD6yJ

AI-skills: none | cmds: /oh-my-claudecode:autopilot

…) fix

Points the test storage deployment at a manually-built image
(quay.io/kubescape/storge:test-sharded-writer-397, built from
kubescape/storage@fix/single-writer-sharded-commits via workflow_dispatch)
instead of the usual dynamic tag, to empirically confirm the sharded
single-writer fix resolves the CI regression (18-19/30 test jobs failing)
before kubescape/storage#397 merges upstream.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LLN3CgGftcnAikV13qD6yJ
@matthyx matthyx added the ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin) label Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 22 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 59177519-57f2-4f98-819b-11064e47a29a

📥 Commits

Reviewing files that changed from the base of the PR and between 1c450e5 and a8d02c0.

📒 Files selected for processing (1)
  • .github/workflows/component-tests.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthyx

matthyx commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Result: 31/32 jobs failed — but this is a false negative, not a real result. The test image was pushed to quay.io/kubescape/storge (note the typo — an existing bug in kubescape/storage's manual build-image workflow, unrelated to the sharded-writer fix itself), and that repo turned out to be private-by-default since it was newly created by this one-off push. The Kind cluster couldn't pull it at all (confirmed via curl https://quay.io/api/v1/repository/kubescape/storgeRequires authentication), so the storage deployment never became ready and every test failed on infrastructure grounds, not on the write-throughput regression this PR is meant to validate.

Rebuilding a corrected test image (pushed to the real public quay.io/kubescape/storage repo, using a private tag that won't touch :latest) and will re-run validation in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant