Match any optional glob token under ByWholeString

TextFilter.Test/TextFilterTests.cs

@@ -608,6 +608,25 @@
 		Assert.IsFalse(TextFilter.IsMatch("B.MD", "*.md", TextFilterType.Glob, TextFilterMatchOptions.ByWholeString, TextFilterCaseSensitivity.CaseSensitive));
 	}
 
+	[TestMethod]
+	public void GlobByWholeStringNeedsOnlyOneOptionalTokenToMatch()
+	{
+		// The glob hint promises "one of the optional tokens". ByWholeString used to require all of
+		// them, so a filter of alternatives such as extension globs matched nothing at all.
+		Assert.IsTrue(TextFilter.IsMatch("photo.jpg", "*.jpg *.png", TextFilterType.Glob, TextFilterMatchOptions.ByWholeString));
+		Assert.IsFalse(TextFilter.IsMatch("notes.txt", "*.jpg *.png", TextFilterType.Glob, TextFilterMatchOptions.ByWholeString));
+		CollectionAssert.AreEqual(
+			new List<string> { "a.jpg", "b.png" },
+			TextFilter.Filter(["a.jpg", "b.png", "c.txt"], "*.jpg *.png", TextFilterType.Glob, TextFilterMatchOptions.ByWholeString).ToList());
+	}
+
+	[TestMethod]
+	public void GlobByWordAllStillNeedsEveryOptionalTokenToMatch()
+	{
+		Assert.IsTrue(TextFilter.IsMatch("red apple", "red* app*", TextFilterType.Glob, TextFilterMatchOptions.ByWordAll));
+		Assert.IsFalse(TextFilter.IsMatch("red apple", "red* pear*", TextFilterType.Glob, TextFilterMatchOptions.ByWordAll));
+	}
+
 	[TestMethod]
 	public void RegexCaseInsensitivityDoesNotDependOnTheCurrentCulture()
 	{

TextFilter/TextFilter.cs

@@ -124,7 +124,7 @@
 	private static readonly TimeSpan RegexMatchTimeout = TimeSpan.FromSeconds(1);
 
 	[System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "SYSLIB1045:Convert to 'GeneratedRegexAttribute'.", Justification = "Not available in older frameworks")]
 	private static Regex RegexMatchAnything() => new(".*", RegexOptions.Compiled);
 
 	/// <summary>
 	/// Gets a hint for the specified filter type.
@@ -276,7 +276,7 @@
 
 			return ExcludedTokenPrefixes.Contains(prefix)
 				? TextFilterTokenType.Excluded
 				: RequiredTokenPrefixes.Contains(prefix)
 				? TextFilterTokenType.Required
 				: TextFilterTokenType.Optional;
 		})
@@ -343,9 +343,9 @@
 			return false; // text contains an excluded token
 		}
 
-		Func<IEnumerable<string>, Func<string, bool>, bool> optionalMatchFunc = textFilterMatchOptions is TextFilterMatchOptions.ByWordAny
-			? Enumerable.Any
-			: Enumerable.All;
+		Func<IEnumerable<string>, Func<string, bool>, bool> optionalMatchFunc = textFilterMatchOptions is TextFilterMatchOptions.ByWordAll
+			? Enumerable.All
+			: Enumerable.Any;
 
 		bool anyOptionalMatches = optionalMatchFunc(optionalTokens, filterToken => AnyTokenMatchesGlobFilter(filterToken, textTokens, caseSensitivity));