Match any optional glob token under ByWholeString - #117
Merged
matt-edmondson merged 2 commits intoSep 27, 2026
Merged
Conversation
DoesMatchGlob combined optional tokens with All for everything except ByWordAny, so ByWholeString required text to satisfy every alternative at once and "*.jpg *.png" matched nothing. Only ByWordAll requires all of them now, which is what the glob hint documents. Fixes #113 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SZUfnvhMFzj96bfFNzbfpn
…'s .gitignore rewrite Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SZUfnvhMFzj96bfFNzbfpn
|
This was referenced Sep 27, 2026
matt-edmondson
deleted the
claude/textfilter-113-bywholestring-optional-any
branch
September 27, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113
What changed
DoesMatchGlobusedAnyto combine optional tokens only for ByWordAny. Every other mode, ByWholeString included, fell through toAll. Under ByWholeString the text is a single token, so a filter of alternatives like"*.jpg *.png"could match nothing. The combinator is nowAllfor ByWordAll andAnyfor everything else. That lines up with the glob hint ("text must contain one of the optional tokens") and with ByWordAny's answer on single-word text.Tests
GlobByWholeStringNeedsOnlyOneOptionalTokenToMatchfails before the fix and passes after it.GlobByWordAllStillNeedsEveryOptionalTokenToMatchchecks that ByWordAll still needs every optional token.This PR is independent of #116 (#112). Both branch from
main, and they touch different lines.🤖 Generated with Claude Code
https://claude.ai/code/session_01SZUfnvhMFzj96bfFNzbfpn
Generated by Claude Code