Skip to content

Add --graphql-no-typename option to exclude typename field#2899

Merged
koxudaxi merged 2 commits intomainfrom
feature/graphql-no-typename
Jan 2, 2026
Merged

Add --graphql-no-typename option to exclude typename field#2899
koxudaxi merged 2 commits intomainfrom
feature/graphql-no-typename

Conversation

@koxudaxi
Copy link
Copy Markdown
Owner

@koxudaxi koxudaxi commented Jan 2, 2026

Fixes: #2095
Closes: #2438
Fixes: #1971

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 2, 2026

Warning

Rate limit exceeded

@koxudaxi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 87445c8 and 5254b05.

⛔ Files ignored due to path filters (1)
  • tests/data/graphql/no-typename.graphql is excluded by !tests/data/**/*.graphql and included by none
📒 Files selected for processing (18)
  • docs/cli-reference/graphql-only-options.md
  • docs/cli-reference/index.md
  • docs/cli-reference/quick-reference.md
  • docs/graphql.md
  • src/datamodel_code_generator/__main__.py
  • src/datamodel_code_generator/_types/generate_config_dict.py
  • src/datamodel_code_generator/_types/parser_config_dicts.py
  • src/datamodel_code_generator/arguments.py
  • src/datamodel_code_generator/cli_options.py
  • src/datamodel_code_generator/config.py
  • src/datamodel_code_generator/parser/graphql.py
  • src/datamodel_code_generator/prompt_data.py
  • tests/data/expected/main/graphql/no_typename.py
  • tests/data/expected/main/input_model/config_class.py
  • tests/data/expected/parser/graphql/no_typename.py
  • tests/main/graphql/test_main_graphql.py
  • tests/main/test_public_api_signature_baseline.py
  • tests/parser/test_graphql.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2026

📚 Docs Preview: https://pr-2899.datamodel-code-generator.pages.dev

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 2, 2026

CodSpeed Performance Report

Merging #2899 will not alter performance

Comparing feature/graphql-no-typename (5254b05) with main (87445c8)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 11 untouched
⏩ 98 skipped1

Footnotes

  1. 98 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (87445c8) to head (5254b05).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2899   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          92       92           
  Lines       16248    16268   +20     
  Branches     1920     1921    +1     
=======================================
+ Hits        16147    16167   +20     
  Misses         52       52           
  Partials       49       49           
Flag Coverage Δ
unittests 99.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@koxudaxi
Copy link
Copy Markdown
Owner Author

koxudaxi commented Jan 2, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 2, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@koxudaxi koxudaxi merged commit 99aac7b into main Jan 2, 2026
39 checks passed
@koxudaxi koxudaxi deleted the feature/graphql-no-typename branch January 2, 2026 16:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2026

Breaking Change Analysis

Result: No breaking changes detected

Reasoning: This PR adds a new opt-in CLI option --graphql-no-typename with a default value of False. The default behavior is unchanged - GraphQL models will still include the typename__ field by default. Users must explicitly pass --graphql-no-typename to exclude the typename field. The change is purely additive: new CLI option, new config parameter in Python API (with default False), and new category "GraphQL-only Options". No existing code generation, templates, default behaviors, or APIs are modified. The regression test test_graphql_typename_included_by_default explicitly confirms backward compatibility.


This analysis was performed by Claude Code Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2026

🎉 Released in 0.52.0

This PR is now available in the latest release. See the release notes for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

option to remove typename__ from graphql input?

1 participant