Skip to content

add exclude-typename-field#2438

Closed
siminchengithub wants to merge 1 commit intokoxudaxi:mainfrom
siminchengithub:graphql-optional-typename-field
Closed

add exclude-typename-field#2438
siminchengithub wants to merge 1 commit intokoxudaxi:mainfrom
siminchengithub:graphql-optional-typename-field

Conversation

@siminchengithub
Copy link
Copy Markdown

@siminchengithub siminchengithub commented Jun 30, 2025

Resolve #2095

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 2, 2025

CodSpeed Performance Report

Merging #2438 will not alter performance

Comparing siminchengithub:graphql-optional-typename-field (e871010) with main (5553dd2)

Summary

✅ 32 untouched benchmarks

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (5553dd2) to head (e871010).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2438   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          66       66           
  Lines        8266     8278   +12     
  Branches      828      829    +1     
=======================================
+ Hits         8112     8124   +12     
  Misses        115      115           
  Partials       39       39           
Flag Coverage Δ
unittests 98.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing sadly.

@gaborbernat gaborbernat marked this pull request as draft July 2, 2025 18:33
@gaborbernat
Copy link
Copy Markdown
Collaborator

Seems this PR stalled, I'll close it now, we can re-open it if you pick it up again, just ping me.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 2, 2026

🎉 Released in 0.52.0

The fix/feature from PR #2899 has been included in this release. See the release notes for details.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

option to remove typename__ from graphql input?

3 participants