chore(submodules): repin hdwallet to master - #400
Merged
Conversation
keepkey/hdwallet PR #59 (clearsign studio + Ironwood, 21 commits) is merged, so the pin the vault was already using is now on master. The release SOP requires tier-1 submodules to be pinned to master, and this was the one outstanding violation for the hdwallet side. Content-identical: db9233f3 and 5ed583db resolve to the same tree (33923a53) — the new SHA is just the merge commit. No rebuild needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keepkey/hdwallet PR #59 (clearsign studio + Ironwood, 21 commits) is merged, so the commit the vault was already pinned to is now on
master. The release SOP requires tier-1 submodules to be pinned to master — this clears the hdwallet half of that blocker.Content-identical repin:
db9233f3and5ed583dbresolve to the same tree (33923a53) — the new SHA is just the merge commit. Nothing to rebuild, no behaviour change.Remaining for the SOP:
modules/device-protocolis pinned to a commit onup/release-protocol(keepkey/device-protocol PR #112, the 7.15 protocol work). That PR is now fully green but needs an approving review before it can merge.