fix(preflight): make the typecheck gate differential instead of unreachable - #401
Merged
Merged
Conversation
…chable Gate 6 demanded exactly zero type errors while the codebase carries a 636-error baseline, so 'make preflight' could never print ALL GATES PASSED. A gate that always fails is a gate everyone learns to ignore — which is how the stale submodule remotes survived: gate 3 was silently comparing against frozen refs and printing green, and nobody was reading the output anyway because gate 6 had already failed the run. Now it compares against a committed .typecheck-baseline and fails only on a REGRESSION, reporting how many errors a change adds. Below baseline prints a nudge to lower the file. This matches how the errors are actually judged in review (differential, per the known false-green from tsc aborting on @types/minimatch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make preflightcould not pass. Gate 6 required exactly zero type errors while the codebase carries a 636-error baseline, so every run ended in❌ ISSUES FOUNDno matter what.That is worse than it sounds: a gate that always fails is a gate everyone learns to skip — and that is exactly how the stale submodule remotes survived. Gate 3 ("upstream behind") was comparing against frozen leftover refs with no configured remote and printing ✅ regardless, and nobody noticed because gate 6 had already failed the run. Both submodule remotes are fixed now, and with honest remotes gate 3 correctly reports
hdwallet: 1 behind origin/master(cleared by #400).Change
Gate 6 now compares against a committed
.typecheck-baseline(636) and fails only on a regression, reporting how many errors the change adds. Coming in under baseline prints a nudge to lower the file. This matches how these errors are already judged in review — differentially, because tsc aborts on@types/minimatchand the absolute count is a known false green.Verified locally: gate 6 now prints
✅ 636 errors, at or below baseline 636.