Skip to content

ci(auto-approve): job-level concurrency so unrelated comments stop cancelling the approval #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilya-bogin-keenable merged 1 commit into from
Sep 30, 2026
Merged

ci(auto-approve): job-level concurrency so unrelated comments stop cancelling the approval #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .github/workflows/auto-approve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,6 @@ on:
issue_comment:
types: [created, edited]

# Qodo edits its persistent review comment on every re-review; when edits land
# in a burst, only the newest matters.
concurrency:
group: auto-approve-${{ github.event.issue.number }}
cancel-in-progress: true

jobs:
approve:
name: Approve on Qodo review
Expand All @@ -29,6 +23,14 @@ jobs:
github.event.comment.user.login == 'qodo-code-review[bot]' &&
github.event.comment.user.type == 'Bot' &&
contains(github.event.comment.body, 'Code Review by Qodo')
# Job-level, not workflow-level: a workflow-level group is joined by EVERY
# comment on the PR (Sonar, Infracost, plans, Qodo's summary), and those
# runs cancelled the one carrying the review before their own `if` skipped
# them. Jobs skipped by `if` never join a job-level group, so only Qodo
# review events compete here; when its edits land in a burst, the newest wins.
concurrency:
group: auto-approve-${{ github.event.issue.number }}
cancel-in-progress: true
runs-on: ubuntu-latest
timeout-minutes: 5
permissions:
Expand Down
Loading