Repository navigation
ci(auto-approve): job-level concurrency so unrelated comments stop cancelling the approval - #73
Merged
Merged
Conversation
…ncelling the approval The approval bridge's workflow-level concurrency group (auto-approve-<PR>) was joined by every comment on the PR: Qodo's summary, SonarCloud, Infracost, tofu plans. Those runs cancelled the one carrying the "Code Review by Qodo" event, then their own job-level `if` skipped them, so the PR never got its recorded approval. That fed the Vanta approved-or-justified test failing. Moving the group to the job means jobs skipped by `if` never join it; only Qodo review events compete. Canonical fix from keenable-integrations, byte-identical copy. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
/review |
Contributor
Author
|
/agentic_review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can route each severity your way: inline, summary, both, or drop |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-approved: Qodo review completed — 🐞 Bugs (0),📘 Rule violations (0) 📎 Requirement gaps (0). Findings are advisory per team policy; verdict source: #73 (comment) [auto-approve.yml]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the approval bridge that sometimes left PRs without their recorded approval (SOC 2 / Vanta
github-code-change-approved-or-justified).Bug:
concurrency: auto-approve-<PR>withcancel-in-progress: truewas declared at the workflow level. Everyissue_commenton the PR joined that group, including Qodo's second comment, SonarCloud, Infracost and plan outputs. Such a comment cancelled the run that carried the "Code Review by Qodo" event, and then its ownifskipped it, so no approval was posted. In the run list this shows ascancelled+skippedruns within the same second.Fix: the same group moves to the job level. A job skipped by
ifnever joins a job-level group, so only real Qodo review events compete, and the newest of them still wins. This changes 1 file and is a byte-identical copy of the canonical fix inkeenable-integrations.🤖 Generated with Claude Code