Skip to content

fix: clearAll() leaks audio files (#101) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karansinghgit merged 2 commits into from
Jul 10, 2026
Merged

fix: clearAll() leaks audio files (#101) #107

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d183ac
fix: clearAll() deletes backing audio files instead of leaking them (…
karansinghgit Jul 10, 2026
4344a86
Merge remote-tracking branch 'origin/main' into fix/clearall-audio-leak
karansinghgit Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions speaktype/Services/HistoryService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ class HistoryService: ObservableObject {
}

func clearAll() {
// Delete the audio files backing every transcript so they don't leak on
// disk (matches `deleteItem`'s `deleteAudioFile: true` default). Stats are
// intentionally preserved — the Clear All dialog promises to keep them.
items.forEach(removeAudioFileIfNeeded(for:))
items.removeAll()
saveHistory()
}
Expand Down
Loading